feat(block-kit): add card block example - #102
Draft
zimeg wants to merge 4 commits into
Draft
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Add a Block Kit card block example mirroring the official docs example, constructed with the slack_sdk CardBlock type (icon, title, subtitle, hero image, body, and an action button). Includes a test asserting the produced block matches the expected JSON and a README bullet. Docs: https://docs.slack.dev/reference/block-kit/blocks/card-block Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Examples should not carry type-checker suppressions. Remove the # type: ignore[arg-type] on the ImageElement icon/hero_image args. Until slackapi/python-slack-sdk#1937 lands (widening CardBlock.icon / hero_image to accept an image element), mypy reports [arg-type] here by design — the honest signal that slack_sdk mis-types these fields as str. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Copy link
Copy Markdown
Member
Author
|
⚠️ mypy is intentionally red on this PR (icon/hero_image [arg-type]). The example builds icon/hero_image with ImageElement — the docs-correct image-element object (carries alt_text for accessibility). slack_sdk currently mis-types CardBlock.icon/hero_image as str | None, so mypy flags the object form. Rather than ship a # type: ignore in an example, the suppression was removed and the fix is upstream: → slackapi/python-slack-sdk#1937 widens those params to accept an image element. Once #1937 lands and releases, this PR's mypy step goes green with no code change here. Tracking so it's not merged/forgotten in the red state. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Block Kit card block example to the block-kit showcase, mirroring the official docs example. The example is constructed using the SDK-provided CardBlock type (imported from slack_sdk.models.blocks) with an icon, title, subtitle, hero image, body, and an action button.
Docs
https://docs.slack.dev/reference/block-kit/blocks/card-block
The example JSON mirrors the docs page (icon, title "Lumon Industries", subtitle, hero image, body, single action button).
Notes
Validation
Ran the repo's CI-equivalent checks for the block-kit showcase (Python 3.13, slack_sdk 3.42.0):
Co-Authored-By: Claude svc-devxp-claude@slack-corp.com
🤖 Generated with Claude Code