chore(deps): update sanic requirement from <24,>=22 to >=22,<25 - #1233
Merged
seratch merged 5 commits intoJan 7, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Updates the requirements on [sanic](https://github.com/sanic-org/sanic) to permit the latest version. - [Release notes](https://github.com/sanic-org/sanic/releases) - [Commits](sanic-org/sanic@v22.3.0...v24.12.0) --- updated-dependencies: - dependency-name: sanic dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #1233 +/- ##
=======================================
Coverage 90.96% 90.96%
=======================================
Files 222 222
Lines 7501 7501
=======================================
Hits 6823 6823
Misses 678 678 ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
Updates the requirements on [sanic](https://github.com/sanic-org/sanic) to permit the latest version. - [Release notes](https://github.com/sanic-org/sanic/releases) - [Commits](sanic-org/sanic@v22.3.0...v24.12.0) --- updated-dependencies: - dependency-name: sanic dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/pip/sanic-gte-22-and-lt-25
branch
from
4a21e03 to
3488d95
Compare
January 3, 2025 21:38
Copy link
Copy Markdown
Contributor
|
It seems something has been changed on Sanic side since v25: ________ ERROR collecting tests/adapter_tests_async/test_async_sanic.py ________
tests/adapter_tests_async/test_async_sanic.py:7: in <module>
from sanic import Sanic
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/sanic/__init__.py:6: in <module>
from sanic.app import Sanic
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/sanic/app.py:50: in <module>
from sanic.application.state import ApplicationState, ServerStage
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/sanic/application/state.py:12: in <module>
from sanic.log import VerbosityFilter, logger
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/sanic/log.py:1: in <module>
from sanic.logging.color import Colors
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/sanic/logging/color.py:8: in <module>
from sanic.helpers import is_atty
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/sanic/helpers.py:[21](https://github.com/slackapi/bolt-python/actions/runs/12604289956/job/35130902961?pr=1233#step:18:22): in <module>
STATUS_CODES: dict[int, bytes] = {
E TypeError: 'type' object is not subscriptable
|
Sorry, something went wrong.
…b.com/slackapi/bolt-python into dependabot/pip/sanic-gte-22-and-lt-25
Copy link
Copy Markdown
Contributor
|
@seratch I made a commit on this PR that changes which version of sanic is installed based on the version of python Python 3.6 -> sanic 20 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@WilliamBergamin Nice! Thanks for resolving it 👍 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the requirements on sanic to permit the latest version.
Release notesSourced from sanic's releases.
CommitsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: