FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add tests around the logger experience of bolt by WilliamBergamin · Pull Request #1270 · slackapi/bolt-python · GitHub

/ bolt-python Public

test: add tests around the logger experience of bolt - #1270

Merged
WilliamBergamin merged 3 commits into
mainfrom
add-test-for-logger-behavior
Mar 13, 2025
ConversationCommits (3)ChecksFiles changed
Merged

test: add tests around the logger experience of bolt#1270
WilliamBergamin merged 3 commits into
mainfrom
add-test-for-logger-behavior

Conversation

WilliamBergamin commented Mar 13, 2025

Copy link
Copy Markdown
Contributor

Summary

This PR aims to add tests around the behavior of loggers used between Bolt and WebClient

This is the first step to solve #1255

Testing

Run the unit tests

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

WilliamBergamin self-assigned this Mar 13, 2025
zimeg approved these changes Mar 13, 2025
View reviewed changes

zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! These are great cases to be covering 🙏

AFAICT this confirms the same logger is used for both the Bolt and WebClient instance, as is, but doesn't change how the logger might be shared in logic?

The linked issue's case isn't so obvious in these tests, but as a first step I'm a fan of these tests 🧪 🔍

codecov Bot commented Mar 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (4185608) to head (8820dde).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1270      +/-   ##
==========================================
+ Coverage   90.94%   90.96%   +0.01%     
==========================================
  Files         222      222              
  Lines        7501     7501              
==========================================
+ Hits         6822     6823       +1     
+ Misses        679      678       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

WilliamBergamin merged commit 9c26945 into main Mar 13, 2025
WilliamBergamin deleted the add-test-for-logger-behavior branch March 13, 2025 20:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zimeg zimeg approved these changes
mwbrooks Awaiting requested review from mwbrooks

Assignees

WilliamBergamin

Labels

area:async area:sync tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL