FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ci: run unit tests on main once a day by zimeg · Pull Request #1319 · slackapi/bolt-python · GitHub

ci: run unit tests on main once a day - #1319

Merged
zimeg merged 3 commits into
mainfrom
zimeg-test-schedule
Jun 27, 2025
Merged

ci: run unit tests on main once a day#1319
zimeg merged 3 commits into
mainfrom
zimeg-test-schedule

Conversation

zimeg commented Jun 25, 2025

Copy link
Copy Markdown
Member

Summary

This PR runs the unit tests once a day to confirm the latest versions of scoped requirements continue to pass 🤖

Related: slackapi/python-slack-sdk#1697
Perhaps also #1317: https://github.com/slackapi/bolt-python/actions/runs/15833832234/job/44799314169

Testing

If this is merged to main I believe the tests will repeat! Reference: schedule

I'm hoping to run the tests in CI with this PR also 👾 ✨

Notes

I'd be open to making a similar change for other testing related workflows, but this might be enough to catch problems soon?

Category

  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

zimeg requested a review from WilliamBergamin June 25, 2025 22:41
zimeg self-assigned this Jun 25, 2025
zimeg added github_actions Pull requests that update GitHub Actions code tests labels Jun 25, 2025

codecov Bot commented Jun 25, 2025
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (7f9ae9c) to head (2be932e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1319   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files         222      222           
  Lines        7501     7501           
=======================================
  Hits         6823     6823           
  Misses        678      678           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zimeg commented Jun 25, 2025

Copy link
Copy Markdown
Member Author

🔍 https://github.com/slackapi/bolt-python/actions/runs/15888693157/job/44806750500?pr=1319#step:11:50

An update to asyncio might be causing CI now to error, but I'm not sure what's causing this?

tests/adapter_tests_async/test_async_asgi.py:60
  /home/runner/work/bolt-python/bolt-python/tests/adapter_tests_async/test_async_asgi.py:60: PytestUnknownMarkWarning: Unknown pytest.mark.asyncio - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    @pytest.mark.asyncio

The plugins from these tests are interesting to me since I'm installing different versions, but am also not sure how to match this:

- plugins: anyio-3.7.1, cov-4.1.0
+ plugins: anyio-4.9.0, cov-6.2.1, asyncio-0.26.0

zimeg left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

📝 And a note of these changes for the kind reviewers!

Comment on lines +8 to +9
schedule:
- cron: "0 0 * * *"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

⌛ This was also a quick value that I'm so open to changing per suggestion 🙏 ✨

https://crontab.guru/#0_0___*

WilliamBergamin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for putting this together 💯

One question before I approve this; if these tests fail where will they report their failure?

zimeg commented Jun 26, 2025

Copy link
Copy Markdown
Member Author

@WilliamBergamin And thank you for the updates to tests 🫡

if these tests fail where will they report their failure?

I've found that "watching" all activity on a project sends failing CI from main to the notifications tab but also this might appear on the last commit to main 🔍

The notifications are something similar to this IIRC:

WilliamBergamin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good 💯

Should we consider using our Github action to send errors to our triage channel?

zimeg merged commit 3529532 into main Jun 27, 2025
zimeg deleted the zimeg-test-schedule branch June 27, 2025 19:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL