FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: move dependencies to pyproject.toml by WilliamBergamin · Pull Request #1360 · slackapi/bolt-python · GitHub

/ bolt-python Public

chore: move dependencies to pyproject.toml - #1360

Merged
WilliamBergamin merged 3 commits into
mainfrom
remove-requirement-file
Sep 9, 2025
ConversationCommits (3)ChecksFiles changed
Merged

chore: move dependencies to pyproject.toml#1360
WilliamBergamin merged 3 commits into
mainfrom
remove-requirement-file

Conversation

WilliamBergamin commented Sep 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Python 3.6 did not support the pip install . command which installs the dependencies of the project, this is why we defined a requirements.txt file at the top level. Now that this project does not support python 3.6 we can get ride of requirements.txt

Testing

CI passes

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

WilliamBergamin added this to the 1.25.0 milestone Sep 9, 2025
WilliamBergamin self-assigned this Sep 9, 2025
WilliamBergamin added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Sep 9, 2025
WilliamBergamin commented Sep 9, 2025
View reviewed changes
Comment thread scripts/build_pypi_package.sh
rm -rf ./slack_bolt.egg-info

pip install -U pip && \
pip install twine build && \

WilliamBergamin Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Minor improvements for consistency

Comment thread .github/dependabot.yml
Comment on lines -15 to -26
- package-ecosystem: "npm"
directory: "/docs"
schedule:
interval: "monthly"
groups:
docusaurus:
patterns:
- "@docusaurus/*"
react:
patterns:
- "react"
- "react-dom"

WilliamBergamin Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Cleaning this up because we don't need it anymore

zimeg Sep 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

📚 praise: Thanks for catching this!

codecov Bot commented Sep 9, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.00%. Comparing base (d6c0c2f) to head (3b49d08).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1360   +/-   ##
=======================================
  Coverage   91.00%   91.00%           
=======================================
  Files         222      222           
  Lines        7512     7512           
=======================================
  Hits         6836     6836           
  Misses        676      676

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zimeg approved these changes Sep 9, 2025
View reviewed changes

zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@WilliamBergamin LGTM! This is such a nice change to keep things fresh 🚢 🫧

Comment thread .github/dependabot.yml
Comment on lines -15 to -26
- package-ecosystem: "npm"
directory: "/docs"
schedule:
interval: "monthly"
groups:
docusaurus:
patterns:
- "@docusaurus/*"
react:
patterns:
- "react"
- "react-dom"

zimeg Sep 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

📚 praise: Thanks for catching this!

Comment thread requirements.txt

zimeg Sep 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🫡 praise: Farewell to requirements.txt indeed.

WilliamBergamin merged commit a3adffa into main Sep 9, 2025
14 checks passed
WilliamBergamin deleted the remove-requirement-file branch September 9, 2025 17:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zimeg zimeg approved these changes

Assignees

WilliamBergamin

Labels

dependencies Pull requests that update a dependency file python Pull requests that update Python code

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL