FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ci: post regression notifications if scheduled tests do not succeed by zimeg · Pull Request #1376 · slackapi/bolt-python · GitHub

/ bolt-python Public

ci: post regression notifications if scheduled tests do not succeed - #1376

Merged
zimeg merged 7 commits into
mainfrom
zimeg-ci-test-notificiations-errors
Sep 30, 2025
ConversationCommits (7)ChecksFiles changed
Merged

ci: post regression notifications if scheduled tests do not succeed#1376
zimeg merged 7 commits into
mainfrom
zimeg-ci-test-notificiations-errors

Conversation

zimeg commented Sep 26, 2025

Copy link
Copy Markdown
Member

Summary

This PR follows #1374 and #1375 to send regression notifications if scheduled tests do not succeed instead of just during failures. Fixes an issue where test timeout did not post a message.

Testing

📺 Planning to add a few commits that confirm !success is the correct operation for both "cancelled" and "failure" states. Since these steps run when scheduled on "main" outside of this PR, these are both events we want to capture I believe.

Category

  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

zimeg self-assigned this Sep 26, 2025
zimeg added github_actions Pull requests that update GitHub Actions code tests labels Sep 26, 2025

codecov Bot commented Sep 26, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.00%. Comparing base (9fa6e86) to head (e768b0c).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1376   +/-   ##
=======================================
  Coverage   91.00%   91.00%           
=======================================
  Files         222      222           
  Lines        7512     7512           
=======================================
  Hits         6836     6836           
  Misses        676      676

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zimeg commented Sep 26, 2025

Copy link
Copy Markdown
Member Author

📚 Reference: https://docs.github.com/en/actions/reference/workflows-and-actions/expressions#status-check-functions

mwbrooks approved these changes Sep 26, 2025
View reviewed changes

mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Great idea!

zimeg commented Sep 30, 2025

Copy link
Copy Markdown
Member Author

@mwbrooks Kind appreciation in the iterations against regression - let's now merge this! 🤖

zimeg enabled auto-merge (squash) September 30, 2025 18:47
zimeg merged commit cb4130a into main Sep 30, 2025
13 checks passed
zimeg deleted the zimeg-ci-test-notificiations-errors branch September 30, 2025 20:27
zimeg mentioned this pull request Oct 3, 2025
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mwbrooks mwbrooks approved these changes
WilliamBergamin Awaiting requested review from WilliamBergamin
srtaalej Awaiting requested review from srtaalej

Assignees

zimeg

Labels

github_actions Pull requests that update GitHub Actions code tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL