| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1441 +/- ##
=======================================
Coverage 90.64% 90.64%
=======================================
Files 226 226
Lines 7182 7187 +5
=======================================
+ Hits 6510 6515 +5
Misses 672 672 ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
|
@srtaalej I also changed the semver tag to be patch! For "experiments" we're planning to release these all under patch versions to avoid signaling more meaningful or stable updates 🐭 |
Sorry, something went wrong.
Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>
Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>
Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>
|
tyty @zimeg for speedy reviews and semver updates 🌠 excited to get this one merged 😁 |
Sorry, something went wrong.
There was a problem hiding this comment.
✅ Great work @srtaalej!
🧪 I haven't manually tested this. Just want to check that one of you have already done it before we merge?
✏️ I left a minor suggestion, I think it's worth a discussion, but we can do it in a 2nd PR!
Sorry, something went wrong.
| channel_id=channel or self._channel_id, # type: ignore[arg-type] | ||
| thread_ts=thread_ts or self._thread_ts, # type: ignore[arg-type] | ||
| status=status, | ||
| loading_messages=loading_messages, |
There was a problem hiding this comment.
suggestion(non-blocking): This can be a follow-up PR (probably better if it is). I think it would be really nice if Bolt provided sensible defaults.
This function is called a lot. So, it'll be nice if developers can start with agent.set_status() and have a solid experience out of the box. Then customize it later.
Sorry, something went wrong.
There was a problem hiding this comment.
i like this idea ⭐ working on it 🫡
Sorry, something went wrong.
There was a problem hiding this comment.
oh and yes i tested using the bolt-python-assistant-template 🚀
Sorry, something went wrong.
There was a problem hiding this comment.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary
Add set_status() to BoltAgent and AsyncBoltAgent for setting assistant thread status directly from the agent listener argument
Testing
Category
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.