FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Remove 'agent: BoltAgent' listener argument by WilliamBergamin · Pull Request #1466 · slackapi/bolt-python · GitHub

/ bolt-python Public

fix: Remove 'agent: BoltAgent' listener argument - #1466

Merged
WilliamBergamin merged 2 commits into
mainfrom
remove-agent-experiment
Mar 20, 2026
ConversationCommits (2)ChecksFiles changed
Merged

fix: Remove 'agent: BoltAgent' listener argument#1466
WilliamBergamin merged 2 commits into
mainfrom
remove-agent-experiment

Conversation

WilliamBergamin commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Summary

The agent class was introduced as an experimental feature, the team has decided to remove it in favor of offering better top level Bolt support for "agent" features.

This PR aims to remove the experimental agent class and its references

Testing

Unit tests should be sufficient 🤔

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

WilliamBergamin added this to the 1.28.0 milestone Mar 19, 2026
WilliamBergamin self-assigned this Mar 19, 2026
WilliamBergamin requested a review from a team as a code owner March 19, 2026 20:26
WilliamBergamin added area:async area:sync semver:patch experiment Experimental feature documented with ExperimentalWarning and pydoc Experiment section labels Mar 19, 2026

codecov Bot commented Mar 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.31%. Comparing base (ba7df02) to head (750ed4b).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1466      +/-   ##
==========================================
- Coverage   91.43%   91.31%   -0.12%     
==========================================
  Files         232      229       -3     
  Lines        7340     7266      -74     
==========================================
- Hits         6711     6635      -76     
- Misses        629      631       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

WilliamBergamin commented Mar 19, 2026

Copy link
Copy Markdown
Contributor Author

@lukegalbraithrussell when this merges then I think we are in the clear to remove the agent experiment form the docs 🙏

WilliamBergamin changed the title fix: remove the agent experiment fix: Remove 'agent: BoltAgent' listener argument Mar 19, 2026
zimeg approved these changes Mar 20, 2026
View reviewed changes

zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@WilliamBergamin LGTM and -1435 is cool 🪓 ✨

Comment thread AGENTS.md

### Kwargs Injection

Listeners receive arguments by parameter name. The framework inspects function signatures and injects matching args: `body`, `event`, `action`, `command`, `payload`, `context`, `client`, `ack`, `say`, `respond`, `logger`, `complete`, `fail`, `agent`, etc. Defined in `slack_bolt/kwargs_injection/args.py`.

zimeg Mar 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

💡 praise: Nice call to update this!

WilliamBergamin merged commit 6406058 into main Mar 20, 2026
16 checks passed
WilliamBergamin deleted the remove-agent-experiment branch March 20, 2026 14:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zimeg zimeg approved these changes
mwbrooks Awaiting requested review from mwbrooks
srtaalej Awaiting requested review from srtaalej
lukegalbraithrussell Awaiting requested review from lukegalbraithrussell

Assignees

WilliamBergamin

Labels

area:async area:sync experiment Experimental feature documented with ExperimentalWarning and pydoc Experiment section semver:patch

Projects

None yet

Milestone

1.28.0

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL