FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: fix test warnings across test suite by WilliamBergamin · Pull Request #1468 · slackapi/bolt-python · GitHub

/ bolt-python Public

chore: fix test warnings across test suite - #1468

Merged
WilliamBergamin merged 9 commits into
mainfrom
fix-some-test-warnings
Mar 23, 2026
ConversationCommits (9)ChecksFiles changed
Merged

chore: fix test warnings across test suite #1468
WilliamBergamin merged 9 commits into
mainfrom
fix-some-test-warnings

Conversation

WilliamBergamin commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR aims to fix some warnings that were showing up in our unit tests 🙏

Testing

CI should be sufficient

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

WilliamBergamin added this to the 1.28.0 milestone Mar 20, 2026
WilliamBergamin self-assigned this Mar 20, 2026
WilliamBergamin requested a review from a team as a code owner March 20, 2026 16:43
WilliamBergamin added python Pull requests that update Python code tests semver:patch labels Mar 20, 2026

codecov Bot commented Mar 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.31%. Comparing base (6e57716) to head (edd539f).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1468   +/-   ##
=======================================
  Coverage   91.31%   91.31%           
=======================================
  Files         229      229           
  Lines        7266     7266           
=======================================
  Hits         6635     6635           
  Misses        631      631

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zimeg approved these changes Mar 20, 2026
View reviewed changes

zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@WilliamBergamin Another amazing change in care for this project 🧪 ✨

Please merge when's right but I left a curious question if the answer is quick-

Comment thread tests/adapter_tests/django/test_django_settings.py Outdated
Comment on lines +4 to +5
"ENGINE": "django.db.backends.sqlite3",
"NAME": "logs/db.sqlite3",
"NAME": ":memory:",

zimeg Mar 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👁️‍🗨️ question: Does this sqlite implementation not use the file system? I haven't explored these tests much but found this surprising at glance!

WilliamBergamin Mar 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good point I found another way to silence the django warning 🙏

WilliamBergamin merged commit 98a8f59 into main Mar 23, 2026
16 checks passed
WilliamBergamin deleted the fix-some-test-warnings branch March 23, 2026 16:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zimeg zimeg approved these changes
mwbrooks Awaiting requested review from mwbrooks
srtaalej Awaiting requested review from srtaalej

Assignees

WilliamBergamin

Labels

python Pull requests that update Python code semver:patch tests

Projects

None yet

Milestone

1.28.0

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL