FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refactor: rename AttachingAgentKwargs middleware to AttachingConversationKwargs by WilliamBergamin · Pull Request #1473 · slackapi/bolt-python · GitHub

/ bolt-python Public

refactor: rename AttachingAgentKwargs middleware to AttachingConversationKwargs - #1473

Merged
WilliamBergamin merged 1 commit into
mainfrom
rename-agent-middleware
Apr 1, 2026
ConversationCommits (1)ChecksFiles changed
Merged

refactor: rename AttachingAgentKwargs middleware to AttachingConversationKwargs#1473
WilliamBergamin merged 1 commit into
mainfrom
rename-agent-middleware

Conversation

WilliamBergamin commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR aims to move away from the "agent" terminology by renaming the AttachingAgentKwargs middleware to AttachingConversationKwargs

Please feel free to share any other naming ideas 🤔

Testing

CI tests should be sufficient

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

WilliamBergamin added this to the 1.28.0 milestone Apr 1, 2026
WilliamBergamin self-assigned this Apr 1, 2026
WilliamBergamin requested a review from a team as a code owner April 1, 2026 18:38
zimeg approved these changes Apr 1, 2026
View reviewed changes

zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@WilliamBergamin LGTM and thanks for discussion prior to these changes 🤓

I'm approving quick with a question of eventual changes - would the say argument find eventual place in these kwargs? I understand this can be a breaking change but I am curious now:

bolt-python/slack_bolt/kwargs_injection/args.py

Line 165 in 39007db

self.say: Say = say

zimeg changed the title chore: rename AttachingAgentKwargs middleware to AttachingConversationKwargs refactor: rename AttachingAgentKwargs middleware to AttachingConversationKwargs Apr 1, 2026

codecov Bot commented Apr 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.32%. Comparing base (8908885) to head (39007db).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1473   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files         229      229           
  Lines        7270     7270           
=======================================
  Hits         6639     6639           
  Misses        631      631

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

WilliamBergamin commented Apr 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I'm approving quick with a question of eventual changes - would the say argument find eventual place in these kwargs? I understand this can be a breaking change but I am curious now:

Yess hopefully say can be brought in this middleware as well in the future 🚀

WilliamBergamin merged commit 9d0e0af into main Apr 1, 2026
16 checks passed
WilliamBergamin deleted the rename-agent-middleware branch April 1, 2026 18:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zimeg zimeg approved these changes
mwbrooks Awaiting requested review from mwbrooks
srtaalej Awaiting requested review from srtaalej

Assignees

WilliamBergamin

Labels

area:async area:sync semver:patch

Projects

None yet

Milestone

1.28.0

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL