FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: handle malformed user/view payloads in extract_team_id by saschabuehrle · Pull Request #1481 · slackapi/bolt-python · GitHub

/ bolt-python Public

fix: handle malformed user/view payloads in extract_team_id - #1481

Merged
WilliamBergamin merged 1 commit into
slackapi:mainfrom
saschabuehrle:fix/issue-1447
Apr 13, 2026
ConversationCommits (1)ChecksFiles changed
Merged

fix: handle malformed user/view payloads in extract_team_id#1481
WilliamBergamin merged 1 commit into
slackapi:mainfrom
saschabuehrle:fix/issue-1447

Conversation

saschabuehrle commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Summary

This prevents extract_team_id() from raising KeyError when malformed payloads contain user or view objects without a team_id key.

Changes

  • use .get("team_id") for payload["user"] and payload["view"] lookup in extract_team_id
  • extend invalid-payload coverage in test_extraction_functions_invalid_dict_keys

Why

Slack requests should still be rejected by request verification, but malformed traffic should not crash context extraction before middleware runs.

Testing

  • python3 -m compileall -q slack_bolt/request/internals.py tests/slack_bolt/request/test_internals.py

Fixes #1447

Greetings, saschabuehrle

saschabuehrle requested a review from a team as a code owner April 11, 2026 16:13
WilliamBergamin approved these changes Apr 13, 2026
View reviewed changes

WilliamBergamin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for catching this edge case @saschabuehrle & contributing 🥇 change look good to me!

The optimal fix for #1447 is to get the RequestVerification middleware to run before the extraction logic, this would involve moving the extraction logic into a middleware which would be a breaking change

This PR in combination with #1464 aim to improve the robustness of the extraction logic so that no errors are thrown before the RequestVerification middleware is ran, for this reason we won't close #1447 just yet

codecov Bot commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.32%. Comparing base (7e9b08b) to head (de75fec).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1481      +/-   ##
==========================================
+ Coverage   91.31%   91.32%   +0.01%     
==========================================
  Files         228      228              
  Lines        7262     7262              
==========================================
+ Hits         6631     6632       +1     
+ Misses        631      630       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

WilliamBergamin merged commit 2266ac7 into slackapi:main Apr 13, 2026
16 checks passed
zimeg added this to the 1.29.0 milestone May 18, 2026
zimeg added bug Something isn't working semver:patch labels Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

WilliamBergamin WilliamBergamin approved these changes

Assignees

No one assigned

Labels

bug Something isn't working cla:signed semver:patch

Projects

None yet

Milestone

1.29.0

Development

Successfully merging this pull request may close these issues.

extract_team_id crashes with TypeError when payload["user"] is a string (e.g. member_joined_channel events)

3 participants

Back | FazBrowse Home | New Git URL