fix: mock module level time to improve stability - #1497
Merged
WilliamBergamin merged 1 commit intoMay 11, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1497 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 228 228
Lines 7262 7262
=======================================
Hits 6632 6632
Misses 630 630 ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
4 tasks
zimeg
approved these changes
May 11, 2026
zimeg
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
@WilliamBergamin LGTM or hawschoooo 😴
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These changes aim to improve the stability of our unit tests by mocking time a the module level rather then the global level, it also provides more roust implementations of the time and sleep mocks
Testing
CI should be sufficient
Category
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.