FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: removing external links for unified nav by haleychaas · Pull Request #1531 · slackapi/bolt-python · GitHub

/ bolt-python Public

docs: removing external links for unified nav - #1531

Merged
haleychaas merged 2 commits into
mainfrom
unified-nav
Jun 12, 2026
ConversationCommits (2)ChecksFiles changed
Merged

docs: removing external links for unified nav#1531
haleychaas merged 2 commits into
mainfrom
unified-nav

Conversation

haleychaas commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

I'm working on uniting the nav bar for all of the tools so that you don't lose the context of the rest of the nav when you click on one of the tools. In this PR, I'm removing the external links (release notes, github repo, contributor's guide) to cut down on bloat in the nav menu when they are all united. Since the github repo and contributor's guide are already mentioned in the landing page, I just added the release notes link to that.

Preview for one nav here: https://docs-slack-d-unified-na-idfrpr.herokuapp.com/tools
PR for unified nav here: https://github.com/slackapi/docs/pull/605

Testing

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

haleychaas requested a review from a team as a code owner June 11, 2026 20:51

codecov Bot commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.34%. Comparing base (96fd215) to head (cd1ec21).
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1531   +/-   ##
=======================================
  Coverage   91.34%   91.34%           
=======================================
  Files         228      228           
  Lines        7279     7279           
=======================================
  Hits         6649     6649           
  Misses        630      630

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

haleychaas requested review from a team and removed request for a team June 11, 2026 20:55
zimeg changed the title Docs: Removing external links for unified nav docs: removing external links for unified nav Jun 11, 2026
zimeg added docs Improvements or additions to documentation semver:patch labels Jun 11, 2026
zimeg added this to the 1.29.0 milestone Jun 11, 2026
zimeg approved these changes Jun 11, 2026
View reviewed changes

zimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@haleychaas LGTM! I'm leaving a comment on ordering from a first impressed read - feel free to merge whenever best! 📰

Comment thread docs/english/index.md Outdated
Comment on lines +23 to +25
## Release notes

Check out the [Bolt for Python release notes](https://github.com/slackapi/bolt-python/releases) for all the latest happenings. No newline at end of file

zimeg Jun 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🧮 suggestion: Is moving "Release notes" before "Contributing" alright for a first read?

  • Getting help
  • Release notes
  • Contributing

haleychaas merged commit 76338bf into main Jun 12, 2026
16 checks passed
haleychaas deleted the unified-nav branch June 12, 2026 17:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zimeg zimeg approved these changes
WilliamBergamin WilliamBergamin approved these changes

Assignees

No one assigned

Labels

docs Improvements or additions to documentation semver:patch

Projects

None yet

Milestone

1.29.0

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL