FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Pass the Bolt logger in default WebClient instantiation by seratch · Pull Request #246 · slackapi/bolt-python · GitHub

/ bolt-python Public

Pass the Bolt logger in default WebClient instantiation - #246

Merged
seratch merged 1 commit into
slackapi:mainfrom
seratch:fix-client-default-logger
Feb 24, 2021
ConversationCommits (1)ChecksFiles changed
Merged

Pass the Bolt logger in default WebClient instantiation#246
seratch merged 1 commit into
slackapi:mainfrom
seratch:fix-client-default-logger

Conversation

seratch commented Feb 23, 2021

Copy link
Copy Markdown
Contributor

This pull request improves the consistency of logging in Bolt. Thanks to @eddyg's feedback in the community workspace: https://community.slack.com/archives/CHL4CLRCZ/p1614000712009600 (if you're not a member of the workspace, you can join from here)

eddyg Feb 22nd at 10:31 PM
Anybody know why create_async_web_client doesn’t take an (optional) logger argument and pass it to AsyncWebClient()? I know AsyncBaseClient has an optional logger arg. so I know I could init my own and pass it as a client arg to AsyncApp(), but I wondered if there was a reason Bolt doesn’t pass down a logger by default? (edited)

seratch:slack: 35 minutes ago
@eddyg good point. actually the logger argument in WebClient was added recently (1 month ago). there is not reason not to update the bolt code.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

seratch added this to the 1.4.2 milestone Feb 23, 2021
seratch self-assigned this Feb 23, 2021

codecov Bot commented Feb 23, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #246 (7374d29) into main (3e483fe) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   91.36%   91.37%           
=======================================
  Files         160      160           
  Lines        4971     4973    +2     
=======================================
+ Hits         4542     4544    +2     
  Misses        429      429
Impacted Files Coverage Δ
...ck_bolt/adapter/aws_lambda/lambda_s3_oauth_flow.py 97.14% <100.00%> (ø)
slack_bolt/app/app.py 86.88% <100.00%> (ø)
slack_bolt/app/async_app.py 94.73% <100.00%> (ø)
slack_bolt/oauth/async_oauth_flow.py 90.75% <100.00%> (ø)
slack_bolt/oauth/oauth_flow.py 90.43% <100.00%> (ø)
slack_bolt/util/async_utils.py 100.00% <100.00%> (ø)
slack_bolt/util/utils.py 94.11% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e483fe...7374d29. Read the comment docs.

stevengill approved these changes Feb 24, 2021
View reviewed changes

stevengill left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks great

seratch merged commit 97a55d8 into slackapi:main Feb 24, 2021
seratch deleted the fix-client-default-logger branch February 24, 2021 23:21
This was referenced Mar 13, 2025
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

stevengill stevengill approved these changes
mwbrooks Awaiting requested review from mwbrooks

Assignees

seratch

Labels

area:adapter area:async area:sync improvement

Projects

None yet

Milestone

1.4.2

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL