Feat x509 validity - #1432
Open
alvidofaisal wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name of feature:
Enable --cert-not-before and --cert-not-after for X.509 certificate tokens
Pain or issue this feature alleviates:
Currently, the step ca token command only supports the --cert-not-before and --cert-not-after flags for SSH certificates. This PR extends this functionality to X.509 certificates, allowing you to enforce specific validity periods for X.509 certificate tokens directly at the time of token creation. This is useful for scenarios where one-time tokens are issued to third parties to enroll for a certificate, and a shorter certificate runtime than the provisioner's maximum is desired.
Why is this important to the project (if not answered above):
This enhancement provides more granular control over certificate validity for X.509 tokens, improving security and flexibility in certificate issuance workflows.
Is there documentation on how to use this feature? If so, where?
The command-line help for step ca token will reflect this change. The public documentation on smallstep.com (specifically https://smallstep.com/docs/step-cli/reference/ca/token/#options) will need to be updated to remove the SSH-only restriction for these flags. (This has been noted as a separate task).
In what environments or workflows is this feature supported?
This feature is supported wherever step ca token is used to generate tokens for X.509 certificates, in both online and offline CA modes.
In what environments or workflows is this feature explicitly NOT supported (if any)?
There are no environments or workflows where this feature is explicitly not supported, beyond the general requirements for using the step ca token command.
Supporting links/other PRs/issues:
💔Thank you!