Add RFC 9399 logotype parsing to inspect command - #1636
Draft
agustinushanssen wants to merge 3 commits into
Draft
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
|
Sorry, something went wrong.
This parses the logotype extension (OID 1.3.6.1.5.5.7.1.12) and prints the URI to the console output. Includes unit tests for all logotype categories.
This parses the logotype extension (OID 1.3.6.1.5.5.7.1.12) and prints the URI to the console output. Includes unit tests for all logotype categories.
agustinushanssen
force-pushed
the
add-rfc9399-logotypes
branch
from
7b0181a to
d050a38
Compare
May 29, 2026 19:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This parses the logotype extension (OID 1.3.6.1.5.5.7.1.12) and prints the URI to the console output. Includes unit tests for all logotype categories.
Name of feature:
Add RFC 9399 logotype parsing to the step certificate inspect command.
Pain or issue this feature alleviates:
Fixes #1359. Previously, the CLI could not extract or display Logotype Extensions (OID 1.3.6.1.5.5.7.1.12). This adds the required ASN.1 structs to safely unmarshal the data and print the Logotype URI directly to the terminal.
Why is this important to the project (if not answered above):
It allows developers and administrators to inspect certificates (like VMCs) that contain embedded SVGs or external branding links without needing to drop down to a raw OpenSSL ASN.1 parser.
Is there documentation on how to use this feature? If so, where?
No new documentation is required; the output automatically appears in the Extensions section when running step certificate inspect <cert>.
In what environments or workflows is this feature supported?
Tested and working locally via make test and manually tested against a production VMC certificate (LinkedIn).
In what environments or workflows is this feature explicitly NOT supported (if any)?
None
Note for reviewers: This initial PR only inspects and prints the URI. It does not natively download or decompress the image to a file. I wanted to get your architectural feedback first: would you prefer a dedicated --export-logotype flag for that in a future PR, or is printing the URI sufficient for now?
Supporting links/other PRs/issues:
Resolves #1359
💔Thank you!