FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Updates to replace pointers with iterators for BAM and SAM inputs by andrewdavidsmith · Pull Request #121 · smithlabcode/falco · GitHub

Updates to replace pointers with iterators for BAM and SAM inputs - #121

Merged
andrewdavidsmith merged 28 commits into
mainfrom
sam-format-updates
Aug 29, 2026
Merged

Updates to replace pointers with iterators for BAM and SAM inputs#121
andrewdavidsmith merged 28 commits into
mainfrom
sam-format-updates

Conversation

andrewdavidsmith commented Aug 29, 2026
edited
Loading

Copy link
Copy Markdown
Collaborator

Minor pessimization of 1-2% seems to result from having functions generated for different underlying types within the function that collects results for each read. This depends on the compiler and is expected to be eliminated with future updates. Edit: The final change to using iterator of underlying vector for samrec is held back because I don't feel I fully understand it.

… get around issues related to using raw pointers and pointer arithmetic
…parently one step before using from_chars recently added to falco namespace in falco_utils.hpp
…get_next function to work with iterators instead of pointers as samrec::pos_t
…light associated cost, because samrec::pos_t is iterators and not raw pointer
…rs. Resetting those iterators in the reset function for sam_file class
…s to iterators in the bamrec class and free function accessors
…ent a tautology when comparing with 255. Now get_next for samrec has types specified
… types in function signatures, moved definition of core_t to bam_core_t out of bamrec class and removed core_t member as it was only ever used in a narrow scope within one function
…al SAM records because I don't understand why the performance characteristics change so dramatically. Leaving this issue for next time.
andrewdavidsmith merged commit b93c13b into main Aug 29, 2026
2 checks passed
andrewdavidsmith deleted the sam-format-updates branch August 29, 2026 03:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL