FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Warn for raise with three compnents by nanjekyejoannah · Pull Request #14 · softdevteam/pygrate2 · GitHub

Repository navigation

Warn for raise with three compnents - #14

Merged
bors[bot] merged 1 commit into
softdevteam:migrationfrom
nanjekyejoannah:raise
Nov 25, 2022
Merged

bors[bot] merged 1 commit into
softdevteam:migrationfrom
nanjekyejoannah:raise

Conversation

Copy link
Copy Markdown
Collaborator

This makes sense at the AST hence isolated from the other exception PR

Copy link
Copy Markdown
Collaborator Author

bors try

bors Bot added a commit that referenced this pull request Nov 24, 2022

bors Bot commented Nov 24, 2022

Copy link
Copy Markdown

try

Build succeeded:

ltratt commented Nov 25, 2022

Copy link
Copy Markdown
Member

bors r+

bors Bot commented Nov 25, 2022

Copy link
Copy Markdown

Build succeeded:

bors Bot merged commit 48f8eb8 into softdevteam:migration Nov 25, 2022
bors Bot added a commit that referenced this pull request Nov 29, 2022
16: Warn for specific thread module methods r=ltratt a=nanjekyejoannah

Dont merge until #13  and  #14 are merged, some helper code cuts across.

This replaces #15 

Threading module Notes

Python 2:

```
>>> from thread import get_ident
>>> from threading import get_ident
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name get_ident
>>> import threading
>>> from threading import _get_ident
>>>
```

Python 3:

```
>>> from threading import get_ident
>>> from thread import get_ident
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'thread'
>
```

**Note:**

There is no neutral way of porting

Co-authored-by: Joannah Nanjekye <jnanjekye@python.org>
bors Bot added a commit that referenced this pull request Feb 16, 2023
24: Warn for exception: move warning to ceval r=ltratt a=nanjekyejoannah

This replaces the old PR: #12
Moved the warning to ceval.

I removed the three component warning because it was committed in an earlier PR here: #14

Co-authored-by: Joannah Nanjekye <jnanjeky@unb.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL