FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[WIP] http4s - migrate from Blaze to Ember by ivan-klass · Pull Request #4185 · softwaremill/tapir · GitHub

/ tapir Public

[WIP] http4s - migrate from Blaze to Ember - #4185

Draft
ivan-klass wants to merge 1 commit into
softwaremill:masterfrom
ivan-klass:http4s-migrate-to-ember
ConversationCommits (1)ChecksFiles changed
Draft

[WIP] http4s - migrate from Blaze to Ember#4185
ivan-klass wants to merge 1 commit into
softwaremill:masterfrom
ivan-klass:http4s-migrate-to-ember

Conversation

ivan-klass commented Nov 25, 2024

Copy link
Copy Markdown
Contributor

Ember seems to be more modern and especially better supported in terms of cross-platform builds

ivan-klass force-pushed the http4s-migrate-to-ember branch from 16a531e to cd1ce53 Compare November 25, 2024 18:53
ivan-klass marked this pull request as ready for review November 25, 2024 18:54
ivan-klass force-pushed the http4s-migrate-to-ember branch 2 times, most recently from 088bbfa to 6aa2b66 Compare November 30, 2024 11:37
ivan-klass force-pushed the http4s-migrate-to-ember branch 2 times, most recently from f0b3c83 to 57c2fa6 Compare December 19, 2024 16:50

adamw commented Dec 19, 2024

Copy link
Copy Markdown
Member

Oh nice, I was worried you abandoned the PR ;)

ivan-klass mentioned this pull request Jan 14, 2025
Merged
ivan-klass marked this pull request as draft January 22, 2025 15:37

ivan-klass commented Jan 23, 2025

Copy link
Copy Markdown
Contributor Author

Will wait for #4267 first

ivan-klass changed the title http4s - migrate from Blaze to Ember [WIP, depends on #4267] http4s - migrate from Blaze to Ember Jan 23, 2025

ivan-klass commented Jan 31, 2025

Copy link
Copy Markdown
Contributor Author

@adamw when you have a chance, could you please take a look on #4267 so I can rebase this PR on top of that?

adamw commented Jan 31, 2025

Copy link
Copy Markdown
Member

@ivan-klass sure thing, done :)

ivan-klass force-pushed the http4s-migrate-to-ember branch from 3fe8b8e to 8b5ea8a Compare February 1, 2025 13:25
ivan-klass changed the title [WIP, depends on #4267] http4s - migrate from Blaze to Ember [WIP] http4s - migrate from Blaze to Ember Feb 1, 2025

ivan-klass commented Mar 7, 2025

Copy link
Copy Markdown
Contributor Author

To whom it may concern: ember builder doesn't have an option for a specific execution context, so test request handling is not in the global one as it was before. It seems like race conditions are observed when dealing with some web-socket tests.

adamw commented Mar 21, 2025

Copy link
Copy Markdown
Member

@ivan-klass sorry for the delay - the global EC was used before only because it was the easiest one to obtain ;). I don't think there's anything in the tests that would rely on the global one being used: each server should be independent anyway, regardless on the thread pool on which tasks/futures are scheduled. So I would look for causes of the exceptions elsewhere, unfortunately.

ivan-klass commented Apr 10, 2025

Copy link
Copy Markdown
Contributor Author

Then there might be a bug in http4-ember then... I'll try to dig in and reproduce when I have time

ivan-klass force-pushed the http4s-migrate-to-ember branch from 195128a to 7b7eda3 Compare July 28, 2025 10:25
ivan-klass mentioned this pull request Jul 28, 2025
Open
ivan-klass mentioned this pull request Feb 17, 2026
Draft
ivan-klass force-pushed the http4s-migrate-to-ember branch 3 times, most recently from 03ec0cb to 56ec296 Compare June 28, 2026 09:56
http4s: Migrate from blaze to ember
3769139 
Replace the blaze server/client backend with ember across the http4s
modules, examples, docs, and perf tests. Includes connection idle
timeout handling, websocket pong/close-frame fixes, multipart decoding
fix, and test interpreter cleanup using ember's default idle timeout.
ivan-klass force-pushed the http4s-migrate-to-ember branch from 56ec296 to 3769139 Compare June 28, 2026 16:31

ivan-klass commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

I hope I've found the underlying problem - http4s/http4s#7882

adamw commented Jul 7, 2026

Copy link
Copy Markdown
Member

@ivan-klass ah nice, would be great to have this merged :)

ivan-klass mentioned this pull request Jul 7, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL