FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ci: restrict ci workflow permissions to read-only by arpitjain099 · Pull Request #86 · solidjs/solid-refresh · GitHub

ci: restrict ci workflow permissions to read-only - #86

Open
arpitjain099 wants to merge 1 commit into
solidjs:mainfrom
arpitjain099:chore/workflow-permissions
Open

ci: restrict ci workflow permissions to read-only#86
arpitjain099 wants to merge 1 commit into
solidjs:mainfrom
arpitjain099:chore/workflow-permissions

Conversation

Copy link
Copy Markdown

Small hardening change: set permissions: contents: read at the top of .github/workflows/ci.yml so the workflow token is read-only instead of inheriting the repository default. The job only does checkout and build/test, so nothing else is required.

Set an explicit least-privilege permissions block so the workflow GITHUB_TOKEN is scoped to contents: read instead of inheriting the repository default.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>

lxsmnsyc commented Jun 2, 2026

Copy link
Copy Markdown
Member

lgtm, no downsides?

Copy link
Copy Markdown
Author

Right, no downsides. The workflow only checks out the repo and runs the build, so its GITHUB_TOKEN never needs more than read. Declaring contents: read at the top just makes that explicit instead of letting the job inherit whatever the repository default grants (often read/write). If a future job in this file ever needs a write scope, it can be added at the job level without widening the rest.

Copy link
Copy Markdown
Author

@lxsmnsyc approved in June and nothing is failing. Is this just waiting on a merge?

Copy link
Copy Markdown
Member

@arpitjain099 sorry I lost repo perms sometime between June and August (possibly by mistake), we'll resolve this. Thanks for the reminder!

Copy link
Copy Markdown
Author

@lxsmnsyc please review when you have time

Copy link
Copy Markdown
Member

@arpitjain099 This is already approved on my end, however like I mentioned I don't have repo perms anymore. I've also notified @ryansolid but he probably missed it couple of times. Let's wait again.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL