chore: code review fixes — deps, CLI arg parsing, CI modernization - #19
Merged
solrevdev merged 7 commits intoJul 16, 2026
Merged
chore: code review fixes — deps, CLI arg parsing, CI modernization#19solrevdev merged 7 commits into
solrevdev merged 7 commits into
Conversation
Copy link
Copy Markdown
Owner
Sorry, something went wrong.
Rewrite the argument-parsing loop in Main() so flags (--help, --version, --list-templates, --dry-run, --force, --quiet, --template/--type/-t) can appear anywhere on the command line instead of only before the folder name; previously `seedfolder myfolder --dry-run` silently ignored the flag. Unknown flags and a second positional argument now produce an error and exit 1. Also remove the unused Colorful.Console package reference, upgrade Figgle to 0.6.6 (fonts moved to the new Figgle.Fonts package) and McMaster.Extensions.CommandLineUtils to 5.1.0, and delete the dead GetDefaultTemplate() helper. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
CLAUDE.md and copilot-instructions.md still described output formatting as using Colorful.Console, which was removed as an unused dependency. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Remove the obsolete/insecure ACTIONS_ALLOW_UNSECURE_COMMANDS flag and the unused setup-nuget step, and switch from the unmaintained rohith/publish-nuget to the actively maintained alirezanet/publish-nuget fork, keeping the same inputs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Add cases exercising --dry-run/--quiet/-t/--force flags placed after (and interleaved around) the folder name argument, plus a case asserting an unknown flag exits non-zero, mirrored in both the bash and PowerShell integration test scripts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The job-level if condition required a push event, so the pull_request trigger never actually ran the build. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code review pass over the repo. All changes verified with a clean Release build across net8.0/net9.0/net10.0, the full integration test suite, and manual smoke tests of the built tool.
Release note
Merging this to master will publish 1.4.1 to NuGet via the updated action.
Test plan
🤖 Generated with Claude Code