FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix language bug by ktrace · Pull Request #1409 · solvespace/solvespace · GitHub

Repository navigation

Fix language bug - #1409

Merged
phkahler merged 1 commit into
solvespace:masterfrom
ktrace:langbug
Sep 20, 2023
Merged

phkahler merged 1 commit into
solvespace:masterfrom
ktrace:langbug

Conversation

ktrace commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

Fix for #1244

Signed-off-by: Victor Kustov <ktrace@yandex.ru>

Copy link
Copy Markdown
Member

@ktrace Can you offer an explanation for how this fixes the problem but was still compiling and working everywhere else?

BTW I reopened the issue since it's apparently still valid and this will close it properly ;-)

phkahler linked an issue Sep 19, 2023 that may be closed by this pull request
phkahler merged commit 1919a18 into solvespace:master Sep 20, 2023

ruevs commented Sep 20, 2023

Copy link
Copy Markdown
Member

@phkahler @ktrace so how indeed does this change work? (I'm not on a PC so I might be missing something. Is the function called in a different scope?)

ruevs commented Sep 22, 2023

Copy link
Copy Markdown
Member

(writing from a computer now with the project open)

There is only one instance of the GraphicsWindow class which is here

GraphicsWindow GW;
and only one instance of the SolveSpaceUI class here
SolveSpaceUI SolveSpace::SS = {};
.

So (unless there is something seriously strange going on) this pull request should not have changed anything.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Segmentation fault on language change

3 participants


Back | FazBrowse Home | New Git URL