slvs: don't try to initially satisfy unsupported constraints - #1562
Merged
phkahler merged 1 commit intoApr 16, 2025
Merged
phkahler merged 1 commit into
phkahler merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
iscgar
force-pushed
the
iscgar/slvs-satisfy
branch
from
3de15f7 to
6494d47
Compare
April 8, 2025 16:27
The current code expects a constraint to only generate a single equation in order to be initially satisfiable. However, some constraints generate more than a single equation, and this hits an assertion. SolveSpace itself only initially satisfies a small subset of constraints, so there is no point in trying to satisfy all types.
iscgar
force-pushed
the
iscgar/slvs-satisfy
branch
from
6494d47 to
b2e8068
Compare
April 11, 2025 07:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current initial satisfaction code expects a constraint to only generate a single equation in order to be initially satisfiable. However, some constraints generate more than a single equation, and this hits an assertion.
SolveSpace itself only initially satisfies a small subset of constraints, so there is no point in trying to satisfy all types.
Fixes #1379