FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

generate: make GenerateAll non recursive and optimise pruning logic by iscgar · Pull Request #1688 · solvespace/solvespace · GitHub

/ solvespace Public

generate: make GenerateAll non recursive and optimise pruning logic - #1688

Open
iscgar wants to merge 1 commit into
solvespace:masterfrom
iscgar:iscgar/non-recursive-regenerate
ConversationCommits (1)ChecksFiles changed
Open

generate: make GenerateAll non recursive and optimise pruning logic#1688
iscgar wants to merge 1 commit into
solvespace:masterfrom
iscgar:iscgar/non-recursive-regenerate

Conversation

iscgar commented Mar 15, 2026

Copy link
Copy Markdown
Contributor

This results in a reduction of up to 50% in regeneration duration since it only prunes sequentially. Pruning should be further optimised so that it avoid traversing the full request and constraint list for every group again.

I had this change sitting in my fork for a few months alreay and just forgot to submit it. Sorry for the delay.

generate: make GenerateAll non recursive and optimise pruning logic
b93862f 
This results in a reduction of up to 50% in regeneration duration since
it only prunes sequentially. Pruning should be further optimised so that
it avoid traversing the full request and constraint list for every group
again.
ruevs force-pushed the master branch 2 times, most recently from 93215ea to bc2bca8 Compare March 28, 2026 09:14

phkahler commented Apr 29, 2026

Copy link
Copy Markdown
Member

@iscgar I'm in favor of this change, and now is a good time to make it - after a release, not just before. @ruevs what do you think?

ruevs commented Apr 30, 2026

Copy link
Copy Markdown
Member

@phkahler I have not looked at this PR closely - sorry. I'll try to do it next week.

Evil-Spirit commented May 5, 2026

Copy link
Copy Markdown
Collaborator

This results in a reduction of up to 50% in regeneration duration since it only prunes sequentially. Pruning should be further optimised so that it avoid traversing the full request and constraint list for every group again.

I had this change sitting in my fork for a few months alreay and just forgot to submit it. Sorry for the delay.

Good Idea since I was not very impressed by double regeneration (but it was me who did it).
But it is better to make your changes separated (optimize pruning and removing double regeneration for chord tolerance calculation should be different commits.)

phkahler mentioned this pull request Jul 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL