FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Don't delete the constraints that the solver couldn't satisfy. by ruevs · Pull Request #1744 · solvespace/solvespace · GitHub

/ solvespace Public

Don't delete the constraints that the solver couldn't satisfy. #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruevs merged 2 commits into from
Jul 29, 2026
Conversation 5 Commits 2 Checks 61 Files changed
Merged

Don't delete the constraints that the solver couldn't satisfy. #1744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfb8a5d
Don't delete the constraints that the solver couldn't satisfy.
BoykoNeov Jul 27, 2026
81f473f
Free the list of constraints that the solver couldn't satisfy.
BoykoNeov Jul 29, 2026
File filter

Filter by extension

Filter by extension .cpp  (3) .slvs  (1) .txt  (1) All 3 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
4 changes: 4 additions & 0 deletions src/generate.cpp
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ void SolveSpaceUI::MarkGroupDirty(hGroup hg, bool onlyThis) {

bool SolveSpaceUI::PruneOrphans() {
const int requests = SK.request.n;
SK.request.ClearTags();
for(Request &r : SK.request) {
if(!GroupExists(r.group))
r.tag = 1;
Expand All @@ -41,6 +42,7 @@ bool SolveSpaceUI::PruneOrphans() {
deleted.requests += requests - SK.request.n;

const int constraints = SK.constraint.n;
SK.constraint.ClearTags();
for(Constraint &c : SK.constraint) {
if(!GroupExists(c.group))
c.tag = 1;
Expand Down Expand Up @@ -106,6 +108,7 @@ bool SolveSpaceUI::PruneRequestsAndConstraints(hGroup hg) {
};

const int requests = SK.request.n;
SK.request.ClearTags();
for(Request &r : SK.request) {
if(r.group != hg) {
continue;
Expand All @@ -121,6 +124,7 @@ bool SolveSpaceUI::PruneRequestsAndConstraints(hGroup hg) {
deleted.requests += requests - SK.request.n;

const int constraints = SK.constraint.n;
SK.constraint.ClearTags();
for(Constraint &c : SK.constraint) {
if(c.group != hg)
continue;
Expand Down
1 change: 1 addition & 0 deletions src/group.cpp
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ const hGroup Group::HGROUP_REFERENCES = { 1 };
// memory. This clears and frees them all.
//-----------------------------------------------------------------------------
void Group::Clear() {
solved.remove.Clear();
polyLoops.Clear();
bezierLoops.Clear();
bezierOpens.Clear();
Expand Down
1 change: 1 addition & 0 deletions test/CMakeLists.txt
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ set(testsuite_SOURCES
core/expr/test.cpp
core/locale/test.cpp
core/path/test.cpp
core/prune/test.cpp
constraint/points_coincident/test.cpp
constraint/pt_pt_distance/test.cpp
constraint/pt_plane_distance/test.cpp
Expand Down
Loading
Loading
Back | FazBrowse Home | New Git URL