Export: warn instead of crashing on freehand/zigzag stipple - #1752
Merged
phkahler merged 1 commit intoAug 5, 2026
Merged
phkahler merged 1 commit into
phkahler merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Fixes solvespace#1506. Exporting a 2D view with a line style that uses the freehand or zigzag stipple pattern crashed with an assertion failure in MakeStipplePattern(), since those patterns have no vector-export equivalent. The on-screen renderer handles them via the OpenGL StippleAtlas, so the crash only occurred on vector export (SVG/PDF/EPS/DXF). Replace the ssassert() with a dbp() warning and fall through to export the line as continuous, so a valid file is produced instead of aborting.
Copy link
Copy Markdown
Member
|
I'll merge this, but I'm going to re-open #1506 because we should be able to export stipple patterns. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
You decided to close it after all? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1506.
Exporting a 2D view with a line style that uses the freehand or zigzag stipple pattern crashed with an assertion failure in MakeStipplePattern(), since those patterns have no vector-export equivalent. The on-screen renderer handles them via the OpenGL StippleAtlas, so the crash only occurred on vector export (SVG/PDF/EPS/DXF).
Replace the ssassert() with a dbp() warning and fall through to export the line as continuous, so a valid file is produced instead of aborting.