Don't crash in the headless CLI when a linked file is missing - #1768
Merged
phkahler merged 1 commit intoSep 28, 2026
Merged
phkahler merged 1 commit into
phkahler merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
A less verbose comment would be nice. Something like: When running the headless CLI version no dialog is possible so: Also, please get the attribution changed to yourself. We've had a few PRs attributed to Claude and I want that to stop happening. |
Sorry, something went wrong.
LocateImportedFile() asks the user whether to look for a linked image or sketch that has moved, but the headless backend has no dialogs to run: CreateMessageDialog() returns an empty handle, which was then dereferenced. Decline to locate the file instead, and name it on the console. Of 171 sketches here, 17 died on load this way, each because of a PNG that had been traced over and has since moved. The GUI is unaffected, since its window exists before the file is loaded.
dodox1
force-pushed
the
fix/headless-missing-linked-file
branch
from
527aa16 to
0c365c4
Compare
September 4, 2026 07:14
Copy link
Copy Markdown
Contributor
Author
|
Both done - comment trimmed to two lines, and the attribution is gone. Sorry |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@dodox1 Thank you for this contribution. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading a sketch whose linked image or sketch has moved kills any headless
build. LocateImportedFile() asks the user whether to look for the file, and
guinone.cpp has no dialogs to run: CreateMessageDialog() returns an empty
handle, which is then dereferenced. The GUI is unaffected — its window exists
before the file is loaded, so the dialog is real.
So it is solvespace-cli that dies: export-mesh, regenerate, thumbnail,
anything batch.
Answer as declining to locate it, which is the only thing a batch run can
sensibly do, and name the file on the console.
Of 171 of my own sketches, 17 died on load this way, every one because of a PNG
that had been traced over and has since moved. With this they all load, and all
17 turn out to be geometrically fine.
Repro: save a sketch with a linked image, move the image, then run
solvespace-cli export-mesh --output out.stl sketch.slvs.