feat(mcp): hide ask_codebase tool when no LLM providers configured by msukkari · Pull Request #1018 · sourcebot-dev/sourcebot · GitHub

Summary

This PR hides the ask_codebase tool in MCP when no language model providers are configured. Previously, the tool was always visible but would return an error when invoked without configured models. Now the tool is simply not registered/visible when there are no models configured.

Changes

Web MCP Server (packages/web/src/features/mcp/server.ts)

Made createMcpServer() async to support checking for configured language models
Added check for hasLanguageModels before registering the ask_codebase tool
Tool is now conditionally registered only when at least one language model is configured

MCP Route Handler (packages/web/src/app/api/(server)/mcp/route.ts)

Updated to await the now-async createMcpServer() function

AGENTS.md

Added note about packages/mcp being deprecated (it should not be modified)

Analysis: Making createMcpServer Async

Confirmed that making createMcpServer async is safe:

The call site is already in an async context (withOptionalAuthV2 callback)
Only adds minimal latency (~1-5ms) for config file read on session creation
No race conditions introduced - session creation is atomic within a request
Error handling is proper - config load failures gracefully return empty models array

Testing

Verified the feature works correctly by testing the MCP API endpoint:

Without models configured (6 tools visible):

list_commits, list_language_models, list_repos, list_tree, read_file, search_code
ask_codebase is NOT visible

With models configured (7 tools visible):

ask_codebase, list_commits, list_language_models, list_repos, list_tree, read_file, search_code
ask_codebase IS visible

All existing tests pass:

yarn test - 617 tests passing
yarn workspace @sourcebot/web lint - No errors
yarn workspace @sourcebot/web build - Successful

Fixes SOU-718

Linear Issue: SOU-718

Summary by CodeRabbit

Changed
- The ask_codebase MCP tool is now hidden when no language model providers are configured, ensuring it's only available when applicable.
Documentation
- Added deprecation notice for obsolete package; MCP functionality is handled elsewhere.

- Modified web MCP server to check configured language models before registering the ask_codebase tool - Made createMcpServer() async to support awaiting the config check - Updated standalone MCP package to check /api/models before registering ask_codebase tool - Tool is now only visible when at least one language model is configured Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 16661059-74a2-441a-97f5-63feb05b5a09

📥 Commits

Reviewing files that changed from the base of the PR and between 6b52d37 and cbf8f25.

📒 Files selected for processing (4)

AGENTS.md
CHANGELOG.md
packages/web/src/app/api/(server)/mcp/route.ts
packages/web/src/features/mcp/server.ts

Walkthrough

This change refactors MCP server initialization to be asynchronous and conditionally registers the ask_codebase tool only when language model providers are configured. The MCP route handler is updated to await async server creation. Documentation is updated to note the deprecation of packages/mcp package and changelog entry for the conditional tool visibility.

Changes

Cohort / File(s)	Summary
Documentation AGENTS.md, CHANGELOG.md	Added deprecation notice for packages/mcp package and changelog entry noting ask_codebase tool is now hidden when no language models are configured.
MCP Server Implementation packages/web/src/features/mcp/server.ts	Changed createMcpServer from synchronous to asynchronous function, added preflight check for configured language models, and conditionally register ask_codebase tool only when language models are available.
MCP Route Handler packages/web/src/app/api/(server)/mcp/route.ts	Updated POST handler to await the now-asynchronous createMcpServer() call before using the server instance.

Sequence Diagram

sequenceDiagram
    participant Client
    participant RouteHandler as Route Handler
    participant ServerInit as Server Init
    participant LMService as LM Service
    participant MCPServer as MCP Server

    Client->>RouteHandler: POST /mcp (new session)
    RouteHandler->>ServerInit: await createMcpServer()
    ServerInit->>LMService: getConfiguredLanguageModels()
    LMService-->>ServerInit: models list
    ServerInit->>MCPServer: new McpServer()
    alt hasLanguageModels = true
        ServerInit->>MCPServer: register ask_codebase tool
    else hasLanguageModels = false
        ServerInit->>MCPServer: skip ask_codebase tool
    end
    MCPServer-->>ServerInit: server instance
    ServerInit-->>RouteHandler: Promise resolved
    RouteHandler->>MCPServer: mcpServer.connect(transport)
    MCPServer-->>Client: connection established

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

feat(mcp): Add optional visibility parameter to control chat visibility #903: Changes ask_codebase MCP tool visibility field and schema/docs alongside this PR's conditional registration logic.
fix(mcp): modify ask_codebase prompt to require explicit call out #995: Modifies tool metadata and behavior for ask_codebase tool in the same server.ts file where conditional registration is now implemented.
feat: gate MCP API behind auth when Ask GitHub is enabled #994: Updates MCP route handlers to add auth guards while this PR modifies the POST handler flow for async server initialization.

Suggested reviewers

brendan-kellam

✨ Finishing Touches 📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch cursor/SOU-718-ask-codebase-tool-visibility-26fc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>

The packages/mcp package is deprecated and should not be modified. Reverted the conditional ask_codebase registration changes from this package. Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>

Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>

…26fc

cursoragent and others added 3 commits March 20, 2026 02:21

docs: add changelog entry for ask_codebase visibility change

5aa8e8a

Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>

revert: remove changes to deprecated packages/mcp

59e133c

The packages/mcp package is deprecated and should not be modified. Reverted the conditional ask_codebase registration changes from this package. Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>

docs: add note about deprecated packages/mcp to AGENTS.md

d42d3ab

Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>

msukkari marked this pull request as ready for review March 20, 2026 17:20

Merge branch 'main' into cursor/SOU-718-ask-codebase-tool-visibility-…

cbf8f25

…26fc

msukkari merged commit 48fb8b1 into main Mar 20, 2026
6 checks passed

msukkari deleted the cursor/SOU-718-ask-codebase-tool-visibility-26fc branch March 20, 2026 17:22

github-actions Bot mentioned this pull request Mar 20, 2026

Sourcebot Roadmap 🚀 #459

Open

coderabbitai Bot mentioned this pull request Apr 21, 2026

feat(web): expose get_diff on MCP server #1142

Merged

4 tasks

coderabbitai Bot mentioned this pull request Jul 2, 2026

fix(web): disambiguate MCP language model selection for ask_codebase #1414

Closed

4 tasks

coderabbitai Bot mentioned this pull request Aug 20, 2026

feat(web): add create_skill, update_skill, and list_skills tools to MCP and Ask Sourcebot #1612

Merged

feat(mcp): hide ask_codebase tool when no LLM providers configured by msukkari · Pull Request #1018 · sourcebot-dev/sourcebot · GitHub

Uh oh!

feat(mcp): hide ask_codebase tool when no LLM providers configured - #1018

feat(mcp): hide ask_codebase tool when no LLM providers configured#1018
msukkari merged 5 commits into
mainfrom
cursor/SOU-718-ask-codebase-tool-visibility-26fc

msukkari commented Mar 20, 2026 •
edited by coderabbitai Bot
Loading

Uh oh!

Uh oh!

coderabbitai Bot commented Mar 20, 2026 •
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(mcp): hide ask_codebase tool when no LLM providers configured by msukkari · Pull Request #1018 · sourcebot-dev/sourcebot · GitHub

Uh oh!

feat(mcp): hide ask_codebase tool when no LLM providers configured - #1018

feat(mcp): hide ask_codebase tool when no LLM providers configured#1018msukkari merged 5 commits intomainsourcebot-dev/sourcebot:mainfrom cursor/SOU-718-ask-codebase-tool-visibility-26fcsourcebot-dev/sourcebot:cursor/SOU-718-ask-codebase-tool-visibility-26fcCopy head branch name to clipboard

Conversation

msukkari commented Mar 20, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Web MCP Server (packages/web/src/features/mcp/server.ts)

MCP Route Handler (packages/web/src/app/api/(server)/mcp/route.ts)

AGENTS.md

Analysis: Making createMcpServer Async

Testing

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram

Estimated code review effort

Possibly related PRs

Suggested reviewers

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(mcp): hide ask_codebase tool when no LLM providers configured#1018
msukkari merged 5 commits into
mainfrom
cursor/SOU-718-ask-codebase-tool-visibility-26fc

msukkari commented Mar 20, 2026 •
edited by coderabbitai Bot
Loading

coderabbitai Bot commented Mar 20, 2026 •
edited
Loading