chore: add lint workflow for PRs - #1200
Merged
brendan-kellam merged 2 commits intoMay 13, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Adds a Lint workflow that fans out via a new root `lint` script (mirroring the existing `test` script's foreach pattern) and fixes the existing no-explicit-any errors in the review-agent test files so the workflow lands green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor
|
@brendan-kellam your pull request is missing a changelog! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ad2fc3ed-0d1d-4260-87b5-f965093f83dc 📥 CommitsReviewing files that changed from the base of the PR and between 3889335 and fd3efee. 📒 Files selected for processing (1)
WalkthroughAdds a GitHub Actions lint workflow (PRs to main) and a root lint script; updates review-agent tests to cast mocked GitHub and GitLab clients using Octokit and GitlabClient types instead of any. ChangesLint workflow and test type safety
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
❌ Failed checks (1 warning)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches 🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands and usage tips. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ℹ️ Review info ⚙️ Run configuration
.github/workflows/lint.yml (1)🤖 Prompt for all review comments with AI agents18-21: ⚡ Quick win
Consider enabling dependency caching for faster CI runs.
The setup-node action supports built-in caching for Yarn dependencies. Adding caching would significantly speed up subsequent workflow runs by reusing installed dependencies.
⚡ Proposed enhancement to enable Yarn caching🤖 Prompt for AI Agents- name: Use Node.js uses: actions/setup-node@v4 with: node-version: '20.x' + cache: 'yarn'Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/lint.yml around lines 18 - 21, Update the GitHub Actions step that uses actions/setup-node@v4 (the block containing node-version: '20.x') to enable built-in dependency caching for Yarn by adding the cache option (cache: 'yarn') and set cache-dependency-path to point at yarn.lock (e.g., cache-dependency-path: '**/yarn.lock'); this will allow setup-node to restore and persist Yarn dependencies across runs and speed up CI.
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. Nitpick comments: In @.github/workflows/lint.yml: - Around line 18-21: Update the GitHub Actions step that uses actions/setup-node@v4 (the block containing node-version: '20.x') to enable built-in dependency caching for Yarn by adding the cache option (cache: 'yarn') and set cache-dependency-path to point at yarn.lock (e.g., cache-dependency-path: '**/yarn.lock'); this will allow setup-node to restore and persist Yarn dependencies across runs and speed up CI.
ℹ️ Review info ⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3ff5a45e-4d37-467f-afa7-0b1f34521512
📥 CommitsReviewing files that changed from the base of the PR and between 70b8c70 and 3889335.
📒 Files selected for processing (6)- .github/workflows/lint.yml
- package.json
- packages/web/src/features/agents/review-agent/nodes/githubPrParser.test.ts
- packages/web/src/features/agents/review-agent/nodes/githubPushPrReviews.test.ts
- packages/web/src/features/agents/review-agent/nodes/gitlabMrParser.test.ts
- packages/web/src/features/agents/review-agent/nodes/gitlabPushMrReviews.test.ts
Sorry, something went wrong.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor
License Audit⚠️ Status: PASS
Weak Copyleft Packages (informational)
|
Sorry, something went wrong.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit