| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
The error banner visibility was only set to true when an error occurred, but was never automatically hidden when the error state was cleared. This caused stale 'Network error' banners to persist even after a new request started successfully. Now the banner visibility is properly synchronized with the error state: - When error is truthy: banner is visible - When error is falsy: banner is hidden This ensures that benign transient errors that get cleared by the AI SDK (e.g. when a new request starts) no longer leave lingering error banners. Fixes SOU-2018 Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: dc2181e9-ff71-4b41-a945-0ca16f78dd76 📥 CommitsReviewing files that changed from the base of the PR and between 3f98f44 and 23efe16. 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. WalkthroughThe chat thread now hides the Ask network-error banner when the chat error clears. The changelog documents this fix. ChangesAsk error banner synchronization
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to 23efe The change keeps the error banner aligned with the current chat error state, hiding it when the error is cleared. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: brendan-kellam 🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Fixes SOU-2018
Problem
Users were seeing a "Network error" message displayed at the top of the Ask page after every question, even though the question would continue and succeed. The error appeared benign but was confusing and degraded the user experience.
Root Cause
The error banner visibility was only set to true when an error occurred, but was never automatically hidden when the error state was cleared by the AI SDK. This caused stale error banners to persist even after:
The problematic code:
This effect only ran when error changed to a truthy value, but did nothing when error became undefined (cleared).
Solution
Changed the effect to properly synchronize banner visibility with the error state:
Now:
This ensures that transient errors that get cleared by the AI SDK (e.g., when a new request starts) no longer leave lingering error banners.
Testing
Linear Issue: SOU-2018
Summary by CodeRabbit
Bug Fixes
Documentation