FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(web): show repository first-sync banner to everyone by brendan-kellam · Pull Request #1615 · sourcebot-dev/sourcebot · GitHub

/ sourcebot Public

fix(web): show repository first-sync banner to everyone - #1615

Open
brendan-kellam wants to merge 2 commits into
mainfrom
brendan/show-repository-first-sync-banner-to-everyone
ConversationCommits (2)ChecksFiles changed
Open

fix(web): show repository first-sync banner to everyone#1615
brendan-kellam wants to merge 2 commits into
mainfrom
brendan/show-repository-first-sync-banner-to-everyone

Conversation

brendan-kellam commented Aug 22, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

  • show the repository first-sync banner to owners, members, and anonymous viewers
  • load repository first-sync counts through optional authentication while keeping failure and warning counts owner-only
  • add coverage for banner audiences and count visibility

Test plan

  • yarn workspace @sourcebot/web test --run src/app/(app)/components/banners/bannerResolver.test.ts src/app/(app)/components/banners/repositoryFirstSyncBanner.test.tsx src/features/repos/repositorySyncCounts.server.test.ts
  • yarn workspace @sourcebot/web lint

Note

Medium Risk
Widens a previously owner-only API to optional auth so first-sync repo counts are visible to members and anonymous users. Failure/warning details remain owner-gated.

Overview
The repository first-sync banner now shows to members and anonymous viewers, not just owners, so people waiting on initial indexing can see progress.

getRepositorySyncCounts uses optional auth and always returns first-sync counts. Failure and warning counts stay owner-only (zeros for everyone else). Layout loads those counts for all roles instead of skipping the fetch for non-owners.

Reviewed by Cursor Bugbot for commit d2bb5f5. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Bug Fixes

    • Repository first-sync notifications now appear for members and anonymous viewers when applicable.
    • Improved visibility of repository synchronization progress during initial setup.
    • Owners continue to receive failure and warning information for repository sync issues.

  • Documentation

    • Added an Unreleased changelog entry describing the first-sync notification fix.

This comment has been minimized.

Sign in to view

coderabbitai Bot commented Aug 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b45807aa-05f2-4afd-99e4-04eec4ef87f7

📥 Commits

Reviewing files that changed from the base of the PR and between 3f98f44 and d2bb5f5.

📒 Files selected for processing (7)
  • CHANGELOG.md
  • packages/web/src/app/(app)/components/banners/bannerResolver.test.ts
  • packages/web/src/app/(app)/components/banners/bannerResolver.tsx
  • packages/web/src/app/(app)/layout.tsx
  • packages/web/src/app/api/(server)/repository-sync-counts/route.ts
  • packages/web/src/features/repos/repositorySyncCounts.server.test.ts
  • packages/web/src/features/repos/repositorySyncCounts.server.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.

Walkthrough

Repository sync counts now load for all viewers. Members and anonymous viewers receive first-sync counts, while failed and warning counts remain owner-only. The first-sync banner audience is now everyone, with updated tests and changelog documentation.

Changes

Repository sync visibility

Layer / File(s) Summary
Optional authentication and sync count computation
packages/web/src/features/repos/repositorySyncCounts.server.ts, packages/web/src/features/repos/repositorySyncCounts.server.test.ts, packages/web/src/app/api/(server)/repository-sync-counts/route.ts		 The sync count service accepts optional authentication, counts visible first-sync repositories for all viewers, and keeps failed and warning counts owner-only. Tests cover the updated results.
Layout count retrieval
packages/web/src/app/(app)/layout.tsx		 The layout retrieves sync counts for every request and retains zero-count fallback handling after errors.
First-sync banner audience
packages/web/src/app/(app)/components/banners/bannerResolver.tsx, packages/web/src/app/(app)/components/banners/bannerResolver.test.ts, CHANGELOG.md		 The first-sync banner targets everyone. Tests verify member and anonymous visibility, and the changelog records the fix.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to d2bb5

This change expands first-sync banner visibility while keeping failure and warning details owner-only; no actionable merge-blocking risk remains beyond normal checks and review.

Sequence Diagram(s)

sequenceDiagram
  participant Viewer
  participant AppLayout
  participant getRepositorySyncCounts
  participant Prisma
  participant BullMQ
  participant BannerResolver

  Viewer->>AppLayout: Open application
  AppLayout->>getRepositorySyncCounts: Request repository sync counts
  getRepositorySyncCounts->>Prisma: Count visible first-sync repositories
  alt Owner viewer
    getRepositorySyncCounts->>BullMQ: Read failed indexing jobs
    getRepositorySyncCounts->>Prisma: Count failed and warning repositories
  end
  getRepositorySyncCounts-->>AppLayout: Return sync counts
  AppLayout->>BannerResolver: Resolve repositoryFirstSync banner
  BannerResolver-->>Viewer: Show banner to everyone
Loading 🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 6 files. (1 skipped: 1 unsupported.) Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: showing the repository first-sync banner to all users.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1 📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch brendan/show-repository-first-sync-banner-to-everyone

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL