fix: Properly enable source maps in all modes - #179
Merged
varungandhi-src merged 1 commit intoAug 4, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
@varungandhi-src This broke our integration: $ yarn global add @sourcegraph/scip-python $ NODE_OPTIONS="--max_old_space_size=8192" scip-python index /usr/bin/env: ‘node --enable-source-maps’: No such file or directory /usr/bin/env: use -[v]S to pass options in shebang lines Shouldn't this be /usr/bin/env -S <...>? What's the intended way to invoke this? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Hmm, I thought I tested that locally. Double-checking; will cut a new release with a fix. |
Sorry, something went wrong.
varungandhi-src
added a commit
that referenced
this pull request
Aug 8, 2025
`env` on different systems behaves differently. On macOS, `env ABC XYZ` will invoke ABC with argument XYZ. On some Linux variants, you need `env -S ABC XYZ` for that. On Alpine, the `-S` flag is not supported, and there is seemingly no way of passing arguments. So this patch undoes the accidental breakage in #179 and uses the `getSourceMapsSupport` API. Technically, both `process.setSourceMapsEnabled` and `module.setSourceMapsSupport` are experimental functions, so to be safe, we do a dynamic existence check before calling them for portability across Node versions.
Copy link
Copy Markdown
Contributor
Author
|
@efritz this should be fixed in the 0.6.2 release. I checked using Docker. Let me know if you're still hitting issues. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to pass --enable-source-maps when launching node,
because Node will not use source maps (even if present) by default.
Additionally, let's avoid the divergence in settings across development
and production.