fix: Make tests more robust & fix path-handling bugs on macOS - #183
Merged
varungandhi-src merged 2 commits intoAug 15, 2025
Merged
fix: Make tests more robust & fix path-handling bugs on macOS#183varungandhi-src merged 2 commits into
varungandhi-src merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
varungandhi-src
force-pushed
the
vg/run-all-tests
branch
23 times, most recently
from
4da1c41 to
321e78f
Compare
August 14, 2025 13:23
varungandhi-src
commented
Aug 14, 2025
Comment thread
packages/pyright-scip/src/MainCommand.ts
Outdated
Comment thread
packages/pyright-scip/snapshots/output/nested_items/src/long_importer.py
Outdated
Comment thread
packages/pyright-scip/src/indexer.ts
Comment thread
packages/pyright-scip/snapshots/output/nested_items/src/long_importer.py
Outdated
varungandhi-src
force-pushed
the
vg/run-all-tests
branch
from
321e78f to
5523524
Compare
August 15, 2025 03:10
varungandhi-src
force-pushed
the
vg/run-all-tests
branch
from
5523524 to
2304a1b
Compare
August 15, 2025 03:16
varungandhi-src
commented
Aug 15, 2025
Comment thread
packages/pyright-scip/src/config.ts
varungandhi-src
force-pushed
the
vg/run-all-tests
branch
from
7ed848c to
bdd47e1
Compare
August 15, 2025 04:36
varungandhi-src
force-pushed
the
vg/run-all-tests
branch
from
bdd47e1 to
f4039c0
Compare
August 15, 2025 04:45
Copy link
Copy Markdown
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sorry, something went wrong.
This was referenced Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So it looks like basically there was a bug where the indexer was
generating 0 documents on macOS (related to the recent bug fix in
https://github.com/sourcegraph/scip-python/pull/177/files where we
started normalizing the file paths passed to setTrackedFiles). 😬
However, the tests were passing on macOS not because they were
correct, but because the zero documents case bypassed the
updating/diffing process. 😢
This patch changes the test diffing logic to be more robust, in handling
various scenarios such as 0 documents. It also introduces a couple
of flags, one for filtering tests, and one for running tests with fail-fast
behavior.
On fixing the tests, I discovered some bugs due to improper handling
of case-sensitivity, so I fixed those (which is why the snapshots are unchanged
and the tests are passing on macOS). For some of these, I'm not super
sure about Pyright behavior, so I added a little assertions library
inspired by Antithesis so that we can test the coverage of different
cases by our test suite on macOS.
See also: https://antithesis.com/docs/best_practices/sometimes_assertions/