fix: split pip show output on the exact package separator - #218
Open
apoorva-01 wants to merge 1 commit into
Open
fix: split pip show output on the exact package separator#218apoorva-01 wants to merge 1 commit into
apoorva-01 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
`\n---` also matches dashed lines inside a package's License (pytest-django), so the block got shredded and indexing died.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scip-python index blows up with Unexpected. Thought I should be getting files now if any dependency's License has a dashed line in it. pytest-django from the issue is the repro.
The pip show fallback splits packages on \n---, but pip actually separates them with a line of just ---. So pytest-django's ----... license rules get read as separators, its block gets shredded, and the parser trips on the leftover. Switched to splitting on the real separator line (/\r?\n---\r?\n/); only the fallback path changed. The test uses the two-package output from the issue and fails if you put the old split back.
(A lone --- on its own line in a license would still trip it, but I haven't seen that happen. Can reset the parser on each Name: instead if you'd rather.)
Closes #173