FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Enable autoSearchPaths to match pyright's CLI by dreddnafious · Pull Request #222 · sourcegraph/scip-python · GitHub

/ scip-python Public

Enable autoSearchPaths to match pyright's CLI #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dreddnafious wants to merge 1 commit into
base: scip
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 0 Commits 1 Checks 1 Files changed
Open

Enable autoSearchPaths to match pyright's CLI #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .ts  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
9 changes: 9 additions & 0 deletions packages/pyright-scip/src/config.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,15 @@ export class ScipPyrightConfig {
// TODO: This probably should be ScipConfig.workspaceroot or similar?
const options = new CommandLineOptions(process.cwd(), false);

// Match pyright's CLI, which always enables this (see pyright.ts:
// "Always enable autoSearchPaths when using the command line.").
// Without it, ensureDefaultExtraPaths() below never adds ./src, so
// src-layout projects resolve definitions under `src.pkg.mod` while
// imports resolve to `pkg.mod`, and cross-package references are lost.
// An explicit extraPaths in pyrightconfig.json / [tool.pyright] still
// takes precedence, so configured projects are unaffected.
options.autoSearchPaths = true;

let config = this._getConfigOptions(host, options);
config.checkOnlyOpenFiles = false;
config.indexing = true;
Expand Down
Back | FazBrowse Home | New Git URL