Fix Windows path separator handling - #224
Open
hoklims wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull request overview
Fixes a Windows startup crash in pyright-scip by removing the platform-derived RegExp(path.sep) (which is invalid on Windows) and replacing it with a safe separator-matching regex that works across both Windows (\) and POSIX (/) path styles.
Changes:
- Replace new RegExp(path.sep, 'g') with a safe cross-platform separator regex (/[\\/]/g).
- Add a regression test ensuring module resolution works with both Windows-style and POSIX-style separators in package file paths.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/pyright-scip/src/virtualenv/PythonEnvironment.ts | Uses a safe, cross-platform separator regex to avoid Windows RegExp initialization crashes and handle mixed path styles. |
| packages/pyright-scip/src/virtualenv/PythonEnvironment.test.ts | Adds coverage to confirm module resolution works for both \ and / separators. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
On Windows, path.sep is \. Passing it directly to new RegExp() creates an invalid regular expression and crashes scip-python during module initialization. This addresses #210.
Accepting both separators also keeps package resolution robust when Python metadata contains mixed path styles.
Validation