This repository was archived by the owner on Sep 30, 2024. It is now read-only.
codeintel: Rewrite integration tester utility - #11686
Merged
efritz merged 5 commits intoJun 25, 2020
Merged
efritz merged 5 commits into
efritz merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #11686 +/- ##
==========================================
+ Coverage 47.13% 47.53% +0.39%
==========================================
Files 1402 1402
Lines 79484 79484
Branches 6775 6764 -11
==========================================
+ Hits 37467 37782 +315
+ Misses 38443 38127 -316
- Partials 3574 3575 +1
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Merging this to unblock (seems fine, it's a private testing util). Will respond to feedback post-merge. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I guess I removed 10k lines of CSV files...?
This effort is mainly a way to decouple the index generation from the upload/query testing. I've moved all index generation to bash scripts and we're now storing indexes in a bucket so that non code intel people (and code intel people not currently working on a particular indexer) do not need to generate the indexes of eleven (and more coming soon) large repositories from scratch to test the API surface.
@uwedeportivo please see if these instructions are adequate to replace the e2e code intel test for releasing going forward. If you can, try to run it given the current instructions in this branch and please let me know if you have any trouble.
This will close https://github.com/sourcegraph/sourcegraph/issues/10832.