This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Code insights: Implement delete insights with new dashboard functionality - #22886
Merged
vovakulikov merged 2 commits intoJul 16, 2021
Merged
Code insights: Implement delete insights with new dashboard functionality #22886vovakulikov merged 2 commits into
vovakulikov merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
24 tasks
valerybugakov
approved these changes
Jul 16, 2021
valerybugakov
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
✅
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We always have this core insight functionality but with the dashboards system, we missed that at some point. This PR brings this functionality back. Currently, we have delete item in the insight context menu component. By click on that, you will delete this insight from all settings subjects and exclude this insight from all code insights dashboards.
Knowing issues
What have been done