feat: warn when src-cli is older than the instance's recommended version - #1338
Open
Montana wants to merge 1 commit into
Open
feat: warn when src-cli is older than the instance's recommended version#1338Montana wants to merge 1 commit into
Montana wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@Montana thanks for your contribution! I think there are some missing parts here. None of the methods added here are used anywhere? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@Montana as mentioned in your other PR. Please add your tests and functionality to this PR. I will close the other two PRs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before running any command, src now does a best-effort check of the running version against the version recommended by the configured Sourcegraph instance (the existing /.api/src-cli/version endpoint) and prints a single warning to stderr when it is behind.
The check is fail-open:
version all result in no warning.
SRC_SKIP_VERSION_CHECK set.
spurious warnings.
Closes #930