Changed variable name struct SensorSettings -> BME280_SensorSettings - #34
Merged
nseidle merged 1 commit intoOct 7, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Good simple fix. Thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You run in to problems when using the BME280 in conjunction with the SparkFun LSM6DS3, as both libraries use the struct name SensorSettings.
When compiling two errors are thrown:
C:...\SparkFun_LSM6DS3_Arduino_Library\src/SparkFunLSM6DS3.h:95:8: error: redefinition of 'struct SensorSettings'
and
C:...\SparkFun_BME280_Arduino_Library\src/SparkFunBME280.h:115:8: error: previous definition of 'struct SensorSettings'
I've found no issues after making the name change from SensorSettings to BME280_SensorSettings.