FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add read burst by cdonate · Pull Request #50 · sparkfun/SparkFun_BME280_Arduino_Library · GitHub

feat: add read burst - #50

Merged
nseidle merged 2 commits into
sparkfun:masterfrom
cdonate:feature/data_burst_readout
Dec 30, 2020
Merged

feat: add read burst#50
nseidle merged 2 commits into
sparkfun:masterfrom
cdonate:feature/data_burst_readout

Conversation

cdonate commented Dec 26, 2020

Copy link
Copy Markdown
Contributor

Read all measurements in one read command
Read Datasheed section 4 Data readout for reason behing this feature

Read all measurements in one read command
Read Datasheed section 4 Data readout for reason behing this feature

nseidle commented Dec 29, 2020

Copy link
Copy Markdown
Member

Hi cdonate - this looks really good but we ask that any large new methods get documented with an example. Do you mind adding one?

add documentation for the default scale on burst read

cdonate commented Dec 30, 2020

Copy link
Copy Markdown
Contributor Author

I've added the example. I was able to test it on a Arduino Uno and DOIT ESP32.

nseidle commented Dec 30, 2020

Copy link
Copy Markdown
Member

Works like a charm and the example looks great. Many thanks!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL