FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

2 examples added by ArminJo · Pull Request #35 · sparkfun/SparkFun_VL53L1X_Arduino_Library · GitHub

  1. sparkfun
  2. SparkFun_VL53L1X_Arduino_Library

Repository navigation

2 examples added - #35

Merged
AndyEngland521 merged 6 commits into
sparkfun:masterfrom
ArminJo:master
Mar 17, 2020
ConversationCommits (6)ChecksFiles changed
Merged

2 examples added#35
AndyEngland521 merged 6 commits into
sparkfun:masterfrom
ArminJo:master

Conversation

ArminJo commented Mar 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hello,
I added 2 examples which were very helpful for me tesing and understanding your distance sensor board.

If you want to use GitHub workflow to test compile your library, have a look at my workflow script. If you like it, I can build you a fork with this script for testing.

Best regards
Armin

AndyEngland521 commented Mar 10, 2020

Copy link
Copy Markdown
Contributor

Hi @ArminJo , these look pretty slick (who doesn't love a plotter for distance).

Can I get you to bump the version number in library.properties up to 1.2.6 so the Arduino IDE takes note of the differences?

Also, I'm very interested in your workflow script. If you wanted to build us a fork I'd love to give it a look!

Thanks for your hard work,
Andy

ArminJo commented Mar 10, 2020

Copy link
Copy Markdown
Contributor Author

Bumping is done.
Armin

ArminJo commented Mar 10, 2020

Copy link
Copy Markdown
Contributor Author

And workflow script is added and running successfully :-).

ArminJo commented Mar 11, 2020

Copy link
Copy Markdown
Contributor Author

Hello @AndyEngland521
I added a few commits for documentation and for covering more examples for the platforms.
I hope it is OK for you.
It is the first real live test for my build script :-)

Thanks
Armin

ArminJo commented Mar 17, 2020

Copy link
Copy Markdown
Contributor Author

Hi Andy,
is there anything I can do?
Or something missing?

Armin

AndyEngland521 commented Mar 17, 2020

Copy link
Copy Markdown
Contributor

Hi Armin,
Sorry, things have been quite hectic around here and I was trying to get a minute to show your script to Nate.

AndyEngland521 merged commit 298d23b into sparkfun:master Mar 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL