FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

first naive implementation of virtual table by duhlin · Pull Request #115 · sparklemotion/sqlite3-ruby · GitHub

/ sqlite3-ruby Public

first naive implementation of virtual table - #115

Open
duhlin wants to merge 10 commits into
sparklemotion:mainfrom
duhlin:master
ConversationCommits (10)ChecksFiles changed
Open

first naive implementation of virtual table#115
duhlin wants to merge 10 commits into
sparklemotion:mainfrom
duhlin:master

Conversation

duhlin commented Dec 6, 2013

Copy link
Copy Markdown
  • see test/test_vtable.rb for example
  • only select is supported (update/insert is not yet implemented)

luislavena reviewed Dec 6, 2013
View reviewed changes
Comment thread ext/sqlite3/module.c Outdated

luislavena Dec 6, 2013

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not sure about this TRACE implementation. Seems to be a debugging leftover when you created this? There is no other parts of the codebase that use this, so I think might need to be removed.

duhlin Dec 6, 2013

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You're right. This macro was for debugging only. It can be safely removed.
Le 6 déc. 2013 17:21, "Luis Lavena" notifications@github.com a écrit :

In ext/sqlite3/module.c:

@@ -0,0 +1,244 @@
+#include <stdio.h>
+#include <sqlite3_ruby.h>
+
+#undef ENABLE_TRACE
+
+#ifdef ENABLE_TRACE
+static FILE* pf;
+# define TRACE(str) \

I'm not sure about this TRACE implementation. Seems to be a debugging
leftover when you created this? There is no other parts of the codebase
that use this, so I think might need to be removed.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/115/files#r8165201
.

lionelperrin commented Mar 29, 2016

Copy link
Copy Markdown

Hello,

@luislavena Is there anything you'd like me to fix/change/review so that this pull request can be integrated ? May be some documentation ?

Regards,

Lionel

lionelperrin and others added 6 commits April 1, 2016 19:41
simplify implementation (and solve GC issue)
06c6659 
* remove class SQLite3::Module and create class SQLite3::VTable
* when declared, store VTables in db.vtables

graf0 commented Nov 4, 2023

Copy link
Copy Markdown

is there a chance to merge vtable feature into sqlite3 gem?

graf0 mentioned this pull request Nov 8, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL