feat: aarch64-mingw-ucrt support - #650
Conversation
Sorry, something went wrong.
|
Thanks for opening this PR. Until I figure out why CI is failing on windows, I'm hesitant to accept additional platforms. I'm hoping to get a chance to investigate those failures soon, but if you're able to help, please do! |
Sorry, something went wrong.
|
Sure thing bud, will see if I get it all green, wouldn't want it to be merged without it. 💚 I don't believe arm64 support is avail via ruby installer for 3.1/3.2/3.3. I know sqlite gems ship with a gem for each supported ruby ABI, would it be okay to have a platform with support for only one ABI (3.4) currently |
Sorry, something went wrong.
|
Should be all green now 💚 https://github.com/YOU54F/sqlite3-ruby/actions/runs/19346654309
I think the rake-compiler-dock bump is the reason the existing CI failures on windows are resolved See PR: #647 |
Sorry, something went wrong.
flavorjones
left a comment
There was a problem hiding this comment.
This looks really good! I just kicked off CI.
Note that I rebased this branch onto latest main.
Sorry, something went wrong.
| recipe.patch_files = Dir[File.join(package_root_dir, "patches", "*.patch")].sort | ||
| end | ||
|
|
||
| # Fix host triplet for Windows ARM64 (native or cross-compilation) |
There was a problem hiding this comment.
Is there an upstream fix pending for this? Is it already in a rubygems release (in which case could we instead pin the required version for this architecture)?
Sorry, something went wrong.
There was a problem hiding this comment.
good question! i need to check that. it is possible this is already corrected, or the change actually needs proposing. i haven’t dug too far as this was sufficient for my needs.
i’ll report back
Sorry, something went wrong.
There was a problem hiding this comment.
@YOU54F just bumping this thread
Sorry, something went wrong.
👋🏾
Would be nice to get a precompiled gem for aarch64-mingw-ucrt now that rake-compiler-dock has support
https://github.com/rake-compiler/rake-compiler-dock/releases/tag/v1.10.0
Similar to
sparklemotion/nokogiri#3530
There is an existing PR for the required version of rake-compiler-dock #647
cross compiled with the applied fix on a macos m4 machine, and successfully installed in a windows-11-arm github actions vm and locally running VM with utm/qemu
There are some test failures regarding support for earlier ruby versions. There is only windows on arm support for Ruby 3.4 provided as part of the rubyinstaller toolking.
PS. If there is a better way to solve this, feel free to close this down, or suggest another approach. This worked for me in trying to add windows-11-arm coverage to some tooling which makes our ruby rack app, available via a github action on any supported actions runner, mainly for CI testing on platforms where docker isn't available.
PPS. I assume feat isn't the right classification for this change!
Cheers!