Fix use-after-free issue with aggregate functions - #711
Merged
flavorjones merged 1 commit intoJun 7, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
if a statement is used after a soft database close. ref: GHSA-j7fr-3v8c-3qc3
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull request overview
This PR addresses a use-after-free scenario involving user-defined aggregate functions when a prepared statement is used after the database has been “soft closed” (via sqlite3_close_v2 semantics), aligning with the linked security advisory.
Changes:
- Add an integration regression test that steps a prepared statement after closing the database and forcing GC.
- Prevent aggregate callback objects from being released on Database#close / discard by no longer clearing the internal -aggregators reference.
- Clarify documentation that aggregate callbacks are retained for the database object’s lifetime.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/test_integration_aggregate.rb | Adds a regression test covering statement use after database close. |
| lib/sqlite3/database.rb | Updates aggregate-function documentation about callback lifetime/retention. |
| ext/sqlite3/database.c | Stops clearing -aggregators on close/discard to avoid freeing callbacks still referenced by open statements. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Comment thread
test/test_integration_aggregate.rb
Comment on lines
+374
to
+376
| values = stmt.step | ||
| assert_equal 33, values[0] | ||
| end |
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if a statement is used after a soft database close.
ref: GHSA-j7fr-3v8c-3qc3