Raise when open_v2 or open16 is called on an open database - #729
Merged
flavorjones merged 1 commit intoAug 11, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The private `open_v2` and `open16` methods could be called on a database that already had a live connection, reachable only via `send` since `initialize` calls them once. The second open replaced the connection and leaked the first `sqlite3*` handle. Both methods will now raise `SQLite3::Exception` when the database already has a live connection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The private open_v2 and open16 methods could be called on a database that already had a live connection, reachable only via send since initialize calls them once. The second open replaced the connection and leaked the first sqlite3* handle.
Both methods now raise SQLite3::Exception when the database already has a live connection.