FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Replace axis= by dim= for calls to Torch (from Samsung, AI Center, Cambridge) by rogiervd · Pull Request #2913 · speechbrain/speechbrain · GitHub

Replace axis= by dim= for calls to Torch (from Samsung, AI Center, Cambridge) - #2913

Merged
pplantinga merged 1 commit into
speechbrain:developfrom
rogiervd:pyright-deprecated
May 16, 2025
Merged

Replace axis= by dim= for calls to Torch (from Samsung, AI Center, Cambridge)#2913
pplantinga merged 1 commit into
speechbrain:developfrom
rogiervd:pyright-deprecated

Conversation

Copy link
Copy Markdown
Contributor

This fixes calls to Torch functions that use axis= (Numpy-style, I suspect) instead of dim=.

These problems were flagged by Pyright (see #2901).

Before submitting
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

pplantinga left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

pplantinga merged commit 1f6192f into speechbrain:develop May 16, 2025
pplantinga pushed a commit to pplantinga/speechbrain that referenced this pull request Jun 2, 2025
…mbridge) (speechbrain#2913)

Co-authored-by: Rogier van Dalen <r.vandalen@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL