FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix `sphinx.writers.text.TextWrapper` by picnixz · Pull Request #13762 · sphinx-doc/sphinx · GitHub

Repository navigation

Fix sphinx.writers.text.TextWrapper - #13762

Merged
AA-Turner merged 9 commits into
sphinx-doc:masterfrom
picnixz:fix/writer/text-table
Nov 29, 2025
Merged

AA-Turner merged 9 commits into
sphinx-doc:masterfrom
picnixz:fix/writer/text-table

Conversation

picnixz commented Jul 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

For now this is a temporary fix because we're still unable to correctly process combining characters (as the tests show). But fixing those cases is much more complex and I think we should rather do something in TextWrapper itself to determine what counts as a "breakable" character. So for now, I'll keep this fix.

Closes #13741

picnixz requested a review from AA-Turner July 26, 2025 12:15
Comment thread CHANGES.rst Outdated

picnixz commented Aug 22, 2025

Copy link
Copy Markdown
Member Author

Did something change in docutils?

jfbu commented Sep 7, 2025

Copy link
Copy Markdown
Contributor

I relaunched the failed Docutils HEAD test and it now passes with current Docutils revision. LaTeX failure was only a duplicate because it uses Docutils HEAD since some time.

See #13845 (comment) and #13845 (comment) for context.

Comment thread CHANGES.rst Outdated
picnixz mentioned this pull request Nov 28, 2025
AA-Turner merged commit cad3c43 into sphinx-doc:master Nov 29, 2025
30 checks passed
picnixz deleted the fix/writer/text-table branch November 29, 2025 08:22
AA-Turner added this to the 9.0.0 milestone Dec 1, 2025
github-actions Bot locked as resolved and limited conversation to collaborators Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text builder hangs with multiple different CSV tables

3 participants


Back | FazBrowse Home | New Git URL