FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Feature/add timestamp to track by nhausman1 · Pull Request #165 · splitio/python-client · GitHub

Feature/add timestamp to track - #165

Open
nhausman1 wants to merge 2 commits into
splitio:masterfrom
nhausman1:feature/add-timestamp-to-track
Open

Feature/add timestamp to track#165
nhausman1 wants to merge 2 commits into
splitio:masterfrom
nhausman1:feature/add-timestamp-to-track

Conversation

Copy link
Copy Markdown

Python SDK

What did you accomplish?

Currently the timestamp for an event is hardcoded as the current time in the track function. This means that you cannot backdate events if, for example, you wanted to run a script every 24 hours that gathers/calculates relevant events and push them to Split. This backdating feature is however supported in Split's JSON Rest API so it will be great to have similar access through the simplified Python API.

Note that this change is non-breaking as I've implemented the logic such that when timestamp isn't specified the logic falls back to time.time().

How do we test the changes introduced in this PR?

Standard build script/test suite. I've added tests for both positive and negative cases.

Copy link
Copy Markdown
Contributor

Hi @nhausman1 ,
Thank you very much for reaching out with this proposal, I will check with our product side to validate whether they're ok with accepting this functionality, and come back to you.

Regards,
Martin.

Copy link
Copy Markdown
Contributor

Hi @nhausman1

While this is something that might be supported on future releases, currently it's still being discussed. I've talked with the SDK PM and we created feature request for this, which would help the product team prioritize it properly.
Unfortunately, we cannot just include your pull request until we figure out how the API will change, and what the exact functionality will be, since this will affect all SDKs and we need to maintain a certain level of consistency between them.

We're truly sorry for any inconveniences this may cause. If all you need to do is to send previously captured events in batches, we can work with you on a small wrapper for our API.

We'll keep your request in mind and probably reach out to you looking for feedback when we start working on the final design for this feature.

Thank you very much for understanding.
Regards,
Martin.

chillaq commented Dec 13, 2022

Copy link
Copy Markdown
Contributor

Hi @nhausman1, Just want to let you know that our Admin API do support posting bulk events allowing specifying the event timestamp.
Checkout this article for more info: https://help.split.io/hc/en-us/articles/9143779240845-Sending-event-data-using-the-Admin-API

Thanks
Bilal

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL