FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

SAO-17698: Address simulation run id review comments by adityamehra · Pull Request #271 · splunk/splunk-ao-python · GitHub

  1. splunk
  2. splunk-ao-python

Repository navigation

SAO-17698: Address simulation run id review comments - #271

Merged
adityamehra merged 3 commits into
agent-simulation-pocfrom
feat/sim-run-id-follow-up
Oct 22, 2026
ConversationCommits (3)ChecksFiles changed
Merged

SAO-17698: Address simulation run id review comments#271
adityamehra merged 3 commits into
agent-simulation-pocfrom
feat/sim-run-id-follow-up

Conversation

adityamehra commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Jira: SAO-18670

  • Normalize non-empty simulation run IDs with validate_simulation_run_id() so callers and exported spans use the same value. Cover whitespace in both public context APIs and converter output.
  • Keep SPLUNK_AO_SIMULATION_RUN_ID in the dependency-light simulation_run_context.py module. Update source and test imports to use it directly, removing the unused converter import.
  • Verify that whitespace-padded IDs export as the normalized splunk_ao.simulation.run_id attribute.

Validation: Ruff passes. The targeted span-converter suite passes (45 tests).

fercor-cisco requested changes Oct 12, 2026
View reviewed changes

fercor-cisco left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Moving SPLUNK_AO_SIMULATION_RUN_ID into simulation_run_context.py makes sense. One blocking issue: the leftover re-export in attribute_mapping.py fails Ruff F401, and the pre-commit hook deletes it automatically, which breaks five test modules. There is also a small test gap on the converter path. Details are inline.

Comment thread src/splunk_ao/converter/attribute_mapping.py Resolved
Comment thread tests/test_splunk_ao_context.py Resolved
adityamehra changed the title SAO-17698: Address review comments SAO-17698: Address simulation run id review comments Oct 22, 2026

adityamehra commented Oct 22, 2026

Copy link
Copy Markdown
Member Author

baz review

adityamehra merged commit ae6885a into agent-simulation-poc Oct 22, 2026
13 checks passed
adityamehra deleted the feat/sim-run-id-follow-up branch October 22, 2026 16:22
github-actions Bot locked and limited conversation to collaborators Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

fercor-cisco Awaiting requested review from fercor-cisco

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL